Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arcade: pass params thru #210

Merged
merged 2 commits into from
Jul 31, 2023
Merged

Arcade: pass params thru #210

merged 2 commits into from
Jul 31, 2023

Conversation

gksander
Copy link
Contributor

@gksander gksander commented Jul 31, 2023

In the arcade, the runQuery playground fn as a second arg for params, which just isn't being handled right now (whoops). This PR passes those params through to the GROQ parsing process to mimic how variables/params work in GROQ. See here for example.

@vercel
Copy link

vercel bot commented Jul 31, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
groqd ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 31, 2023 6:40pm

Copy link
Contributor

@maxyinger maxyinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@gksander gksander merged commit bf32fda into main Jul 31, 2023
4 checks passed
@gksander gksander deleted the arcade-variables branch July 31, 2023 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants