Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify subquery usages with array #232

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Clarify subquery usages with array #232

merged 1 commit into from
Oct 31, 2023

Conversation

carbonrobot
Copy link
Contributor

@carbonrobot carbonrobot commented Oct 31, 2023 •
edited
Loading

Adds clarifying language to the documentation around the isArray option and how to properly dereference arrays in a subquery.

Closes #226

@vercel Vercel
Copy link

vercel bot commented Oct 31, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
groqd ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 31, 2023 3:01pm

@carbonrobot carbonrobot self-assigned this Oct 31, 2023
@carbonrobot carbonrobot added the documentation Improvements or additions to documentation label Oct 31, 2023
maxyinger
maxyinger approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@maxyinger maxyinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. thanks for the additions.

Just for reference, here's the initial PR that spawned the addition of the isArray arg in case you missed it.

We also have the groqd arcade which outputs the groq string for a given query and it has rich linking incase you want to link to it at all in the docs:
https://formidable.com/open-source/groqd/arcade?data=pokemon&code=JYWwDg9gTgLgBAbzlArgOwIooKZQJ5wC%2BcAZlBCHAERgA2AhngObnoAmVA3AFCiSyI4ARyKlylKiwhCOPbqkw58ACm5xhygOQAqANoB9GHjDY4AXjPVIAa2wgIaKgF1NAGkHAAzgEEoURgBccDCopoQAlGpwAHSetMAAxtjKAAzuAByR6tEs9ABGyghR6mj0INhBQrEhwGhMyuGuxXD0MDD0CdZBulR59J7Y0d5tHdZU7lVoKCB5uA1OTeoR3OGcQA

@carbonrobot
Copy link
Contributor Author

@littlemilkstudio Great! I think I will file a new issue to cover adding Arcade links to various places in the docs, so we can consistently have those.

@carbonrobot carbonrobot merged commit 0847736 into main Oct 31, 2023
5 checks passed
@carbonrobot carbonrobot deleted the chore/docs-subquery branch October 31, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxyinger maxyinger maxyinger approved these changes

Assignees

@carbonrobot carbonrobot

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dereferencing nested arrays
2 participants
@carbonrobot @maxyinger