Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

groq-builder: fixed build issues #260

Merged
merged 2 commits into from
Jan 25, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/static-analysis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,9 @@ jobs:

- name: Build library
run: pnpm run build:lib

- name: Type Check
run: pnpm run typecheck

- name: Lint
run: pnpm run lint
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"typecheck:shared": "tsc --project tsconfig.shared.json --noEmit",
"typecheck": "pnpm run typecheck:shared && pnpm run -r typecheck",
"check:ci": "pnpm run typecheck && pnpm run lint && pnpm run test",
"build:lib": "pnpm run --filter groqd build",
"build:lib": "pnpm run --filter groqd --filter groq-builder build",
"build:packages": "pnpm run --filter groqd --filter groqd-playground build",
"build": "pnpm run -r build",
"changeset": "changeset",
Expand Down
3 changes: 2 additions & 1 deletion packages/groq-builder/src/commands/select$.ts
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,8 @@ GroqBuilder.implement({
"When using 'select', either all conditions must have validation, or none of them. " +
`Missing validation: "${missing.join('", "')}"`
);
Error.captureStackTrace(err, GroqBuilder.prototype.select$);
// This only works on V8 engines:
(Error as any).captureStackTrace?.(err, GroqBuilder.prototype.select$);
throw err;
}

Expand Down
5 changes: 4 additions & 1 deletion packages/groq-builder/tsconfig.json
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
{
"extends": "../../tsconfig.json"
"extends": "../../tsconfig.json",
"compilerOptions": {
"target": "ES2019",
}
}
Loading