Bump sanity/ui to version 2 in groqd-playground #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a130574 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
carbonrobot
commented
Apr 19, 2024
| @@ -1,2 +1,3 @@ | |||
| strict-peer-dependencies=false | |||
| prefer-workspace-packages=true | |||
| auto-install-peers=true | |||
There was a problem hiding this comment.
This was already set in the lock file, likely due to someone having it set per-machine. Setting it here so it applies to all developers that run pnpm i
scottrippey
reviewed
Apr 19, 2024
| "react": "^18.2.0", | ||
| "react-dom": "^18.2.0", | ||
| "react-is": "^18.2.0", | ||
| "sanity": "^3.15.0", | ||
| "styled-components": "^5.3.9" | ||
| "styled-components": "^5.2 || ^6" |
There was a problem hiding this comment.
❤️ (fix for issues with the latest Sanity version)
scottrippey
approved these changes
Apr 19, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps sanity ui to version 2 and supports multiple versions of styled-components.
There is a version mismatch in sanity packages where @sanity/ui requires styled-components@^6 and @sanity requires styled-components@^5. The features we use are compatible across both versions so we allow both as a peer dependency to resolve warnings when consumers install our playground package.