Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v8 Rewrite #1043
v8 Rewrite #1043
Changes from 41 commits
e507904
efc3871
d09e8bf
2658ca0
a6c7d4d
f0c08ee
111c8af
5fae4f2
dd02cf9
ca23f2b
3724ab7
13624e3
0556406
90160fa
87577a0
5eedae8
aa4669f
909e3a4
85438c0
49e3429
d3d6e83
7ebe168
1db7dcc
5bcf9ea
64437cc
63031b8
ce84a45
717f4d3
f3e55fe
50e3aab
d8eb4e0
83c8a14
a910126
8225b60
54fc328
e1ad237
638b378
bcf2cf1
3f4df56
2ab32e1
9bd5d8e
bc36817
495b25f
c2e59d2
b8ae41f
a2bd014
3b433b7
6dfa9b7
8df4843
9437cf8
33a587f
3394b93
fa72093
61033de
864bd24
7df950d
4bbfa39
56f9915
2a6bdab
9ad5c30
fb2337a
7d030cd
3b818da
356e710
5cacb02
db05774
623dee3
1952505
8c14687
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without showing the actual code used in the demo, this example is confusing. The description talks about applying a style to the wrapper, and although thats what we did here, we used
gap-4
which alters the children of the wrapper which may confuse people into thinking we meant the wrapper of the slide and not of the carousel.I recommend we consider an alternative name for this property that better describes what it will apply to. Consider something like
carouselClassName
or perhaps just the nativeclassName