Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add aria-hidden flag to svg for textsize util to fix accessibility issue #2661

Merged
merged 2 commits into from
Oct 18, 2023
Merged

Add aria-hidden flag to svg for textsize util to fix accessibility issue #2661

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5be3faa
add aria-hidden flag to svg for textsize util to fix accessibility issue
noranda Oct 12, 2023
37a08cb
Changeset [skip ci]
carbonrobot Oct 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/many-suns-hang.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"victory-core": patch
"victory": patch
---

Add aria-hidden flag to svg for textsize util to fix accessibility issue
1 change: 1 addition & 0 deletions packages/victory-core/src/victory-util/textsize.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,6 +270,7 @@ const _getMeasurementContainer = memoize(() => {
element.setAttribute("width", "300");
element.setAttribute("height", "300");
element.setAttribute("viewBox", "0 0 300 300");
element.setAttribute("aria-hidden", "true");

const containerElement = document.createElementNS(
"http://www.w3.org/2000/svg",
Expand Down