Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#2941): prevent unique clipId from incrementing on rerender #2971

Closed

Conversation

coston
Copy link

@coston coston commented Nov 15, 2024

Description

  1. ensure that uniqueId() is called only once and not on every re-render
  2. Store the result so that is initialized only once

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Manual testing for this one.

Screenshots

Before:

After:

Checklist: (Feel free to delete this section upon completion)

  • I have included a changeset if this change will require a version change to one of the packages.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have run all builds, tests, and linting and all checks pass
  • I have added tests that prove my fix is effective or that my feature works
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Copy link

vercel bot commented Nov 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
victory ✅ Ready (Inspect) Visit Preview Nov 15, 2024 4:25pm

Copy link
Contributor

Folder/File Previous size New size Difference
/packages/victory/dist/victory.min.js 385.54KB 385.58KB +0.04KB (+0.01%)
TOTAL +0.04KB

@coston
Copy link
Author

coston commented Nov 15, 2024

This was a multi-tasking false-positive. It's is not the fix.

@coston coston closed this Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant