Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Handle error bar empty theme object #3046

Merged
merged 4 commits into from
Jan 31, 2025

Conversation

masiddee
Copy link
Contributor

@masiddee masiddee commented Jan 31, 2025

Description

Add default borderWidth value

Fixes #3038

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Pass an empty object to the theme property of VictoryErrorBar component

Checklist: (Feel free to delete this section upon completion)

  • I have included a changeset if this change will require a version change to one of the packages.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have run all builds, tests, and linting and all checks pass
  • I have added tests that prove my fix is effective or that my feature works
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Copy link

changeset-bot bot commented Jan 31, 2025

🦋 Changeset detected

Latest commit: 5a56034

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages
Name Type
victory-errorbar Patch
victory Patch
victory-area Patch
victory-axis Patch
victory-bar Patch
victory-box-plot Patch
victory-brush-container Patch
victory-brush-line Patch
victory-candlestick Patch
victory-canvas Patch
victory-chart Patch
victory-core Patch
victory-create-container Patch
victory-cursor-container Patch
victory-group Patch
victory-histogram Patch
victory-legend Patch
victory-line Patch
victory-native Patch
victory-pie Patch
victory-polar-axis Patch
victory-scatter Patch
victory-selection-container Patch
victory-shared-events Patch
victory-stack Patch
victory-tooltip Patch
victory-vendor Patch
victory-voronoi-container Patch
victory-voronoi Patch
victory-zoom-container Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jan 31, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
victory ✅ Ready (Inspect) Visit Preview Jan 31, 2025 7:17pm

@masiddee masiddee requested a review from nlkluth January 31, 2025 19:18
Copy link
Contributor

Folder/File Previous size New size Difference
/packages/victory/dist/victory.min.js 386.05KB 386.05KB +0KB (+0.00%)
TOTAL +0KB

@masiddee masiddee merged commit 4aafb3d into main Jan 31, 2025
7 checks passed
@masiddee masiddee deleted the fix/errorbar-default-borderwidth branch January 31, 2025 22:05
@fmd-ci fmd-ci mentioned this pull request Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ErrorBar with empty theme bug
2 participants