Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Map: Onion Ocean #224

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

alexoutsold
Copy link

No description provided.

@Sophilautia
Copy link
Collaborator

Sophilautia commented Jul 18, 2024

Hi @alexoutsold

Please complete the board submission form here: https://forms.gle/E1fwdGCHuAxhDLPr9

You will need to upload the background and music to google drive in a zip, the background files (except the map icon) will need to be removed from your Pull Request.

@Sophilautia
Copy link
Collaborator

Also noticed these errors in the validation:

Additional properties are not allowed ('capitalShopNames' was unexpected)
YAML files shall no longer contain the line '---' or '...'

@Ennesan
Copy link
Contributor

Ennesan commented Aug 24, 2024

There are no authors listed in the Onion.YAML file.

@Sophilautia
Copy link
Collaborator

Right, @alexoutsold this needs a couple of changes.

  1. Yaml needs author section
  2. Yaml needs changelog section
  3. Max Dice Roll is set to 7, but Venture Card 87 is enabled. Venture Card 87 makes the player roll either a 7 or an 8, which can work, but can also cause issues since this value being higher than the Max Dice Roll makes it very hard to test pathing for. Please either change the max dice roll to 8 or change Venture Card 87 to something else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants