New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement internal cropping instead of library's built-in function #401

Open

terofeev wants to merge 1 commit into FossifyOrg:master from terofeev:dont-save-copy-after-edit-picture

terofeev commented Feb 7, 2025

What is it?

Bugfix
Feature
Codebase improvement

Description of the changes in your PR

Fix saving an unnecessary copy when cropping and resizing a picture.
Reuse the library's built-in progress bar to indicate the cropping process.

Before/After Screenshots/Screen Record

Before:

Before.mp4

After:

After.mp4

Fixes the following issue(s)

Fixes After edit picture, a copy is saved in app data #378

Acknowledgement

I read the contribution guidelines.


          Implement internal cropping instead of library's built-in function

6e5802f

naveensingh self-assigned this

Member

naveensingh commented Feb 7, 2025 •

edited

Loading

Thanks for the PR!

A temporary file is still created when you press the share button.
Alternatively, we could build, pass, manage a custom output Uri ourselves, that seems to be the "recommended" solution by the developer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet