Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the case where the process group gets removed without the addresses being included #2147

Merged
merged 4 commits into from
Oct 18, 2024

Conversation

johscheuer
Copy link
Member

Description

Fixes a bug where the process group gets removed from the FoundationDBCluster status without getting the addresses included. The side effect of this bug is that some addresses in the cluster are not included again. The issue will only happen if multiple process groups should be replaced across different zones.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Discussion

Testing

Updated the test cases and ran the e2e test for this with an extended inclusion delay.

Documentation

Follow-up

@johscheuer johscheuer added the bug Something isn't working label Oct 17, 2024
@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: a2fc1a7
  • Duration 4:10:20
  • Result: ❌ FAILED
  • Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@johscheuer johscheuer closed this Oct 17, 2024
@johscheuer johscheuer reopened this Oct 17, 2024
@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: a2fc1a7
  • Duration 2:58:04
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@johscheuer johscheuer merged commit e5fd090 into FoundationDB:main Oct 18, 2024
7 of 8 checks passed
@johscheuer johscheuer deleted the fix-inclusion-logic branch October 18, 2024 13:58
@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: 2e6a9e6
  • Duration 3:21:44
  • Result: ❌ FAILED
  • Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: 5e0c8fd
  • Duration 3:30:55
  • Result: ❌ FAILED
  • Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants