Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure that the remove cluster is skipped too and add more debugging output for the plugin #2154

Merged

Conversation

johscheuer
Copy link
Member

Description

Setting the remove cluster into the skip mode, should make the tests more reliable and reduce the risk of a race condition.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Discussion

Testing

Ran the e2e test for the plugin manually.

Documentation

0

Follow-up

#2153 (will e fixed in another PR).

@johscheuer johscheuer added the bug Something isn't working label Oct 21, 2024
@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: 8cd8377
  • Duration 2:52:45
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

Copy link
Member

@brownleej brownleej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@johscheuer johscheuer merged commit e426237 into FoundationDB:main Oct 23, 2024
8 checks passed
@johscheuer johscheuer deleted the correct-plugin-e2e-test-setup branch October 23, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants