Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to batch the exclusions of transaction system processes together #2158

Conversation

johscheuer
Copy link
Member

Description

The changes of this PR try to batch the exclusions of transaction system processes together, e.g. stateless and transaction processes. This should reduce the number of exclusions (and recoveries). This change will be useful as the stateless pods are normally scheduled faster than the transaction/log pods as they have to wait for the volume to be provisioned.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

It's not a correctness bug but the operator will be issuing more exclusions than required.

Discussion

Testing

Added new unit tests and CI will run the e2e tests.

Documentation

Added docs in the code.

Follow-up

@johscheuer johscheuer added the bug Something isn't working label Oct 25, 2024
@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: 94179cf
  • Duration 2:43:37
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

Copy link
Member

@brownleej brownleej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@brownleej brownleej merged commit f80c420 into FoundationDB:main Oct 28, 2024
7 of 8 checks passed
@johscheuer johscheuer deleted the try-to-batch-transaction-system-exclusions branch November 4, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants