Ensure the the cluster reconciler status is set to be in simulation after each test #2160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicmorales9
approved these changes
Nov 4, 2024
johscheuer
commented
Nov 4, 2024
Result of fdb-kubernetes-operator-pr on Linux CentOS 7
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a testing bug that was introduced in https://github.com/FoundationDB/fdb-kubernetes-operator/pull/2158/files#diff-d0ad2e8f0d701fc00f8cd16ca0799d0e7e3a6a508245c60e122770680d3498a5R897. The
clusterReconcileris a global struct, so the value was never set back totrue, which causes failures in some test cases.Type of change
Please select one of the options below.
Discussion
Testing
Ran unit test manually with the race flag.
Documentation
Follow-up