Skip to content

Conversation

johscheuer
Copy link
Member

Description

Move the update status into a single place and update the status only once if required per reconciliation.

Type of change

  • Other

Discussion

This makes it easier to write the sub-reconcilers and should reduce possible conflicts.

Testing

Ran the operator test suite with the new changes.

Documentation

Follow-up

@johscheuer johscheuer force-pushed the move-update-status-single-place branch from 91330a0 to f1d622b Compare September 8, 2025 16:59
@foundationdb-ci
Copy link
Contributor

Result of fdb-kubernetes-operator-pr on Linux RHEL 9

  • Commit ID: 91330a0
  • Duration 0:03:15
  • Result: ❌ FAILED
  • Error: git checkout failed with exit status 128: fatal: unable to read tree (91330a09e8461285b75118b0bf1e5dfda573e5eb) for primary source and source version 91330a09e8461285b75118b0bf1e5dfda573e5eb
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

Result of fdb-kubernetes-operator-pr on Linux RHEL 9

  • Commit ID: f1d622b
  • Duration 2:14:56
  • Result: ❌ FAILED
  • Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@johscheuer johscheuer closed this Sep 9, 2025
@johscheuer johscheuer reopened this Sep 9, 2025
@johscheuer johscheuer marked this pull request as ready for review September 9, 2025 09:00
@foundationdb-ci
Copy link
Contributor

Result of fdb-kubernetes-operator-pr on Linux RHEL 9

  • Commit ID: f1d622b
  • Duration 4:07:08
  • Result: ❌ FAILED
  • Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@johscheuer johscheuer closed this Sep 9, 2025
@johscheuer johscheuer reopened this Sep 9, 2025
@foundationdb-ci
Copy link
Contributor

Result of fdb-kubernetes-operator-pr on Linux RHEL 9

  • Commit ID: f1d622b
  • Duration 2:47:50
  • Result: ❌ FAILED
  • Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)


originalStatus := cluster.Status.DeepCopy()
startTime := time.Now()
defer func() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there any scenario where we don't want to do the update? like if there is an error on a subreconciler?

@johscheuer johscheuer marked this pull request as draft September 23, 2025 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants