Make YAML tests pass connection options to servers for transaction setups #3638
+74
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hazefully
force-pushed
the
transaction-setup-with-connection-options
branch
from
88d5af0 to
9d8e6e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes transactional setups within a
test_blockin YAML tests make use of the specifiedconnection_optionsfor a block when making use of a gRPC server for testing, which is now possible thanks to the work introduced in #3557 to pass theconnection_optionsas part of the request for the remote JDBC connection.In addition, this PR also makes it possible to specify
connection_optionsfor asetupblock, making it possible to use different connections options for different setup blocks within the same YAML test.