Improved performance and memory

FoundryMC · May 16, 2024 · 9d2314c · 9d2314c
1 parent f2fafd0
commit 9d2314c
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 135 deletions.
diff --git a/src/main/java/foundry/veil/example/VeilExampleModClient.java b/src/main/java/foundry/veil/example/VeilExampleModClient.java
@@ -27,7 +27,7 @@ public void onInitializeClient() {
 
         FabricVeilRenderLevelStageEvent.EVENT.register((stage, levelRenderer, bufferSource, poseStack, projectionMatrix, renderTick, partialTicks, camera, frustum) -> {
             if (stage == VeilRenderLevelStageEvent.Stage.AFTER_LEVEL) {
-                MirrorBlockEntityRenderer.renderLevel(Minecraft.getInstance().level, bufferSource, poseStack, projectionMatrix, partialTicks, VeilRenderBridge.create(frustum), camera);
+                MirrorBlockEntityRenderer.renderLevel(Minecraft.getInstance().level, projectionMatrix, partialTicks, VeilRenderBridge.create(frustum), camera);
             }
         });
     }

diff --git a/src/main/java/foundry/veil/example/client/render/DebugFrustumRenderer.java b/src/main/java/foundry/veil/example/client/render/DebugFrustumRenderer.java
diff --git a/src/main/java/foundry/veil/example/client/render/MirrorBlockEntityRenderer.java b/src/main/java/foundry/veil/example/client/render/MirrorBlockEntityRenderer.java
@@ -36,7 +36,6 @@
 import net.minecraft.core.Vec3i;
 import net.minecraft.resources.ResourceLocation;
 import net.minecraft.server.packs.resources.ResourceManager;
-import net.minecraft.util.Mth;
 import net.minecraft.world.level.block.state.BlockState;
 import net.minecraft.world.phys.AABB;
 import net.minecraft.world.phys.Vec3;
@@ -47,7 +46,6 @@
 import java.lang.Math;
 import java.nio.IntBuffer;
 import java.util.Map;
-import java.util.stream.IntStream;
 
 import static org.lwjgl.opengl.GL11C.*;
 import static org.lwjgl.opengl.GL30C.glGenerateMipmap;
@@ -59,6 +57,8 @@ public class MirrorBlockEntityRenderer implements BlockEntityRenderer<MirrorBloc
 
     private static final Matrix4f RENDER_MODELVIEW = new Matrix4f();
     private static final Matrix4f RENDER_PROJECTION = new Matrix4f();
+    private static final Vector4f OBLIQUE_PLANE = new Vector4f();
+    private static final Quaternionf VIEW = new Quaternionf();
 
     private static final ObjectSet<BlockPos> RENDER_POSITIONS = new ObjectArraySet<>();
     private static final Long2ObjectMap<MirrorTexture> TEXTURES = new Long2ObjectArrayMap<>();
@@ -74,6 +74,10 @@ private static long getKey(BlockPos pos, Direction face) {
 
     @Override
     public void render(MirrorBlockEntity blockEntity, float f, PoseStack poseStack, MultiBufferSource multiBufferSource, int i, int j) {
+        if (VeilLevelPerspectiveRenderer.isRenderingPerspective()) {
+            return;
+        }
+
         BlockPos pos = blockEntity.getBlockPos();
         Direction facing = blockEntity.getBlockState().getValue(MirrorBlock.FACING);
 
@@ -139,7 +143,7 @@ private static float dot(BlockPos pos, Vec3i normal, double x, double y, double
         return (float) ((pos.getX() + 0.5 - normal.getX() * 0.5 - x) * normal.getX() + (pos.getY() + 0.5 - normal.getY() * 0.5 - y) * normal.getY() + (pos.getZ() + 0.5 - normal.getZ() * 0.5 - z) * normal.getZ());
     }
 
-    public static void renderLevel(ClientLevel level, MultiBufferSource.BufferSource bufferSource, PoseStack poseStack, Matrix4fc projection, float partialTicks, CullFrustum frustum, Camera camera) {
+    public static void renderLevel(ClientLevel level, Matrix4fc projection, float partialTicks, CullFrustum frustum, Camera camera) {
         if (VeilLevelPerspectiveRenderer.isRenderingPerspective() || !projection.isFinite()) {
             return;
         }
@@ -183,9 +187,9 @@ public static void renderLevel(ClientLevel level, MultiBufferSource.BufferSource
 
             new Quaternionf().lookAlong(dir, up).transform(plane);
 
-            CalculateObliqueMatrix(RENDER_PROJECTION, plane);
+            calculateObliqueMatrix(RENDER_PROJECTION, plane, RENDER_PROJECTION);
 
-            VeilLevelPerspectiveRenderer.render(fbo, RENDER_MODELVIEW.identity(), RENDER_PROJECTION, renderPos, new Quaternionf().lookAlong(dir, up), RENDER_DISTANCE, partialTicks);
+            VeilLevelPerspectiveRenderer.render(fbo, RENDER_MODELVIEW, RENDER_PROJECTION, renderPos, VIEW.lookAlong(dir, up), RENDER_DISTANCE, partialTicks);
             mirror.copy(fbo);
             mirror.setRendered(true);
         }
@@ -205,14 +209,15 @@ public static void renderLevel(ClientLevel level, MultiBufferSource.BufferSource
         RENDER_POSITIONS.clear();
     }
 
-    public static void CalculateObliqueMatrix(Matrix4f projection, Vector4fc clipPlane) {
-        Vector4f q = projection.invert(new Matrix4f()).transform(new Vector4f(
-                Math.signum(clipPlane.x()),
-                Math.signum(clipPlane.y()),
+    public static void calculateObliqueMatrix(Matrix4fc projection, Vector4fc c, Matrix4f store) {
+        Vector4f q = projection.invert(new Matrix4f()).transform(
+                Math.signum(c.x()),
+                Math.signum(c.y()),
+                1.0f,
                 1.0f,
-                1.0f));
-        Vector4f c = clipPlane.mul(2.0F / (clipPlane.dot(q)), new Vector4f());
-        projection.m02(c.x - projection.m03()).m12(c.y - projection.m13()).m22(c.z - projection.m23()).m32(c.w - projection.m33());
+                OBLIQUE_PLANE);
+        float dot = c.dot(q);
+        store.m02(c.x() * 2.0F / dot - projection.m03()).m12(c.y() * 2.0F / dot - projection.m13()).m22(c.z() * 2.0F / dot - projection.m23()).m32(c.w() * 2.0F / dot - projection.m33());
     }
 
     @Override

diff --git a/src/main/resources/assets/veil-example-mod/pinwheel/framebuffers/mirror.json b/src/main/resources/assets/veil-example-mod/pinwheel/framebuffers/mirror.json
@@ -1,7 +1,5 @@
 {
   "depth": true,
-  "width": 2048,
-  "height": 2048,
   "format": "RGB8",
   "autoClear": false
 }