feat(musiccast): Implement MusicCast Source #279
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FoxxMD
added
enhancement
4 tasks
net/usb is more likely to be used since it has more sources. Likely using it will reduce required fetches in most usage scenarios.
* Check for zero duration before using progress bar in debug logging * Adds tests for scrobble thresholds to make sure 0 duration is handled
Prevents some positional player logic from running on a functionally-useless value
…th duration-based calculation
FoxxMD
force-pushed
the
GH-274/musiccast
branch
from
369f2a0 to
0dca49a
Compare
* SOURCE_SCROBBLE_DURATION env sets default duration * SOURCE_SCROBBLE_PERCENT env sets default percent
📦 A new release has been made for this pull request.To play around with this PR, pull an image:
Images are available for x86_64 and ARM64.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Type of change
Please delete options that are not relevant.
Describe your changes
Add Yamaha MusicCast as a Source
Issue number and link, if applicable
#274