feat: implement orama search for active members and staff members #799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
WalkthroughThe update integrates Orama search into the Active Members and Staff components of the website, enhancing search functionality with features like suggestions and sorting. The search now asynchronously interacts with the newly implemented Orama context, improving the user experience by delivering more relevant results. Changes
Assessment against linked issues
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChat with CodeRabbit Bot (
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files ignored due to filter (2)
- package.json
- yarn.lock
Files selected for processing (10)
- .husky/_/.gitignore (1 hunks)
- src/components/ActiveMembers.js (2 hunks)
- src/components/Staff.js (1 hunks)
- src/context/OramaProvider.js (1 hunks)
- src/context/schemas/activemembersSchema.js (1 hunks)
- src/context/schemas/staffmembersSchema.js (1 hunks)
- src/data/activemembers.js (4 hunks)
- src/pages/_app.js (1 hunks)
- src/pages/active-members.js (1 hunks)
- src/pages/staff.js (1 hunks)
Files skipped from review due to trivial changes (2)
- .husky/_/.gitignore
- src/pages/_app.js
Additional comments: 11
src/context/schemas/activemembersSchema.js (1)
- 1-17: The schema definition for active members appears to be consistent and correct. It defines the expected data types for each field, which should help ensure data integrity when interacting with the Orama search library.
src/context/schemas/staffmembersSchema.js (1)
- 1-18: The schema definition for staff members is consistent and correct, similar to the active members schema. It defines the data types for each field, which is important for maintaining data integrity with the Orama search library.
src/pages/staff.js (1)
- 1-15: The integration of
OramaProviderin theHomecomponent is done correctly. ThestaffmembersSchemaandstaffdata are passed as props toOramaProvider, which is necessary for initializing the search context.src/pages/active-members.js (1)
- 1-15: The
OramaProvideris correctly implemented in theHomecomponent for the active members page, withactivemembersSchemaandactiveMembersdata passed as props. This ensures that the search context is initialized with the correct schema and data.src/context/OramaProvider.js (1)
- 1-51: The
OramaProvidercomponent is well-implemented. It uses React hooks effectively to manage the search database state and provides a search function through context. The use ofuseEffectto initialize the database anduseCallbackfor the search function are appropriate for performance optimization.src/components/Staff.js (1)
- 1-40: The
Staffcomponent correctly uses theOramaContextto access thesearchDatabasefunction. The asynchronoussearchHandleris implemented properly to handle search operations and update the state with the results.src/components/ActiveMembers.js (1)
- 1-38: The
ActiveMemberscomponent is updated to use theOramaContextfor search functionality. The asynchronoussearchHandlerfunction is correctly implemented to interact with the search context and update the component's state based on the results.src/data/activemembers.js (4)
154-160: Normalizing the
198-201: Changing the
contributionsfield fromnullto0is a correct approach to ensure numerical data consistency across the dataset.207-210: Standardizing the
contributionsfield to0instead ofnullis a good practice for maintaining data integrity and ensuring that numerical operations on this field do not encounter type-related errors.225-228: The normalization of the
contributionsfield to0is consistent with the rest of the dataset and helps maintain a uniform data type for this field.
1 task
kkrishguptaa
suggested changes
Dec 31, 2023
There was a problem hiding this comment.
I tried debugging your issue, it is actually quite simple, you forgot to format the files
Please go ahead and run 'npm run lint --fix' to fix the issues!
Terminal of how I fixed your issue for reference:
@xkrishguptaa ➜ /workspaces/4c-site (feat-implement-orama-search-779) $ yarn run build
yarn run v1.22.19
$ next build
Failed to compile.
./src/context/OramaProvider.js
10:23 Warning: Unexpected space before function parentheses. space-before-function-paren
13:9 Error: Extra semicolon. semi
15:22 Error: Extra semicolon. semi
17:50 Error: Extra semicolon. semi
18:6 Error: Extra semicolon. semi
info - Need to disable some ESLint rules? Learn more here: https://nextjs.org/docs/basic-features/eslint#disabling-rules
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
@xkrishguptaa ➜ /workspaces/4c-site (feat-implement-orama-search-779) $ yarn lint --fix
yarn run v1.22.19
$ eslint "src/**/**/*.{js,json,jsx,ts,tsx}" --fix
Done in 4.95s.
@xkrishguptaa ➜ /workspaces/4c-site (feat-implement-orama-search-779) $ yarn run build
yarn run v1.22.19
$ next build
✓ Linting and checking validity of types
⚡ Million.js 2.6.4
- Tip: enable { mute: true } to disable info logs
- Hotline: https://million.dev/hotline
⚡ <Footer> now renders ~55% faster
⚡ <Loading> now renders ~100% faster
warn - As of Tailwind CSS v3.3, the `@tailwindcss/line-clamp` plugin is now included by default.
warn - Remove it from the `plugins` array in your configuration to eliminate this warning.
✓ Creating an optimized production build
✓ Compiled successfully
✓ Collecting page data
✓ Generating static pages (7/7)
✓ Collecting build traces
✓ Finalizing page optimization
Route (pages) Size First Load JS
┌ ○ / 6.95 kB 135 kB
├ └ css/431944509084d071.css 2.19 kB
├ /_app 0 B 86.8 kB
├ ○ /404 181 B 87 kB
├ ○ /active-members (475 ms) 4.75 kB 158 kB
├ ○ /joinourteam 52.5 kB 180 kB
├ ○ /projects 14 kB 142 kB
└ ○ /staff 1.43 kB 155 kB
+ First Load JS shared by all 94.6 kB
├ chunks/framework-0c7baedefba6b077.js 45.4 kB
├ chunks/main-5de5daa30cb39434.js 32.9 kB
├ chunks/pages/_app-3e02cfbcc910abe6.js 7.7 kB
├ chunks/webpack-32f7cd90361c570e.js 879 B
└ css/931727bcc480884b.css 7.77 kB
- (Static) automatically rendered as static HTML (uses no initial props)
Done in 49.17s.
@xkrishguptaa ➜ /workspaces/4c-site (feat-implement-orama-search-779) $
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files ignored due to filter (2)
- package.json
- yarn.lock
Files selected for processing (1)
- src/context/OramaProvider.js (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- src/context/OramaProvider.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented Orama search functionality for the Active Members and Staff pages.
Fixes: #779
Summary by CodeRabbit
New Features
ActiveMemberscomponent.Staffcomponent to use context and asynchronous searches.OramaProviderfor centralized database management and search capabilities.Enhancements
ActiveMemberscomponent.Documentation
Refactor
Appcomponent for better readability.Layoutcomponents withOramaProviderin active members and staff pages for context provision.Style
.gitignorein the.huskydirectory to ignore all contents.