Skip to content

Commit

Permalink
Fix deprecation warning from new ggplot2 (#42)
Browse files Browse the repository at this point in the history
* very important

* add everything, migrate to new travis, get ready for CRAAAAAAAN

* doc

* updoot
  • Loading branch information
FrankPortman authored Jun 24, 2021
1 parent 9db6f46 commit 8fe3353
Show file tree
Hide file tree
Showing 88 changed files with 1,571 additions and 1,199 deletions.
1 change: 1 addition & 0 deletions .Rbuildignore
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,4 @@
^todo$
^docs$
^_pkgdown\.yml$
^pkgdown$
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -11,3 +11,4 @@ vignettes/*.html
todo
R/flow.R
R/checks2.R
docs
1 change: 1 addition & 0 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ before_install:

r_packages:
- covr
- plumber

after_success:
- Rscript -e 'covr::codecov(line_exclusions = list("R/bandit.R", "src/init.cpp", "R/plotDists.R" = 80:106, "R/makePlots.R" = 43:95, "R/dists.R" = 42:48))'
6 changes: 3 additions & 3 deletions DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
Package: bayesAB
Type: Package
Title: Fast Bayesian Methods for AB Testing
Version: 1.1.2
Date: 2019-07-02
Version: 1.1.3
Date: 2021-06-24
Authors@R: person("Frank", "Portman", email = "frank1214@gmail.com", role = c("aut", "cre"))
Description: A suite of functions that allow the user to analyze A/B test
data in a Bayesian framework. Intended to be a drop-in replacement for
Expand All @@ -14,7 +14,7 @@ Imports:
methods,
rlang (>= 0.4.0)
LinkingTo: Rcpp
RoxygenNote: 6.1.0
RoxygenNote: 7.1.1
Encoding: UTF-8
URL: https://github.com/FrankPortman/bayesAB
BugReports: https://github.com/FrankPortman/bayesAB/issues
Expand Down
5 changes: 5 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
# bayesAB 1.1.3

## Minor Changes
* Fix ggplot2 deprecation warning introduced in latest version.

# bayesAB 1.1.2

## Minor Changes
Expand Down
2 changes: 1 addition & 1 deletion R/makePlots.R
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ samplePlot <- function(A, B, name, percentLift, f = function(a, b) (a-b)/b) {
ggplot2::xlab('(A - B) / B') +
ggplot2::ylab('Density') +
ggplot2::ggtitle(paste0('Histogram of (A - B) / B Samples : ', name)) +
ggplot2::guides(fill = FALSE)
ggplot2::guides(fill = "none")

p

Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# bayesAB

[![Travis-CI Build Status](https://travis-ci.org/FrankPortman/bayesAB.svg?branch=master)](https://travis-ci.org/FrankPortman/bayesAB) [![codecov](https://codecov.io/gh/FrankPortman/bayesAB/branch/master/graph/badge.svg)](https://codecov.io/gh/FrankPortman/bayesAB) [![CRAN_Status_Badge](http://www.r-pkg.org/badges/version/bayesAB)](https://CRAN.R-project.org/package=bayesAB)
[![Travis-CI Build Status](https://travis-ci.com/FrankPortman/bayesAB.svg?branch=master)](https://travis-ci.com/github/FrankPortman/bayesAB) [![codecov](https://codecov.io/gh/FrankPortman/bayesAB/branch/master/graph/badge.svg)](https://codecov.io/gh/FrankPortman/bayesAB) [![CRAN_Status_Badge](http://www.r-pkg.org/badges/version/bayesAB)](https://CRAN.R-project.org/package=bayesAB)


## Fast Bayesian Methods for AB Testing
Expand Down
8 changes: 4 additions & 4 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
## Version 1.1.2 Submission
Minor release for fixing a bug caused by latest release of ggplot2. No API changes.
## Version 1.1.3 Submission
Minor release for fixing a deprecation warning caused by latest release of ggplot2. No API changes.

## Test environments
- local OS X install, R 3.6.0
- ubuntu 14.04 (on travis-ci), R 3.6.0
- local OS X install, R 4.0.3
- ubuntu 14.04 (on travis-ci), R 4.0.3
- win-builder (devel and release)

## R CMD check results
Expand Down
49 changes: 35 additions & 14 deletions docs/LICENSE-text.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 8fe3353

Please sign in to comment.