Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle InitializerListExpressions as variables of ComprehensionExpressions in the DFG #2016

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

KuechA
Copy link
Contributor

@KuechA KuechA commented Jan 31, 2025

Adapts the ControlFlowSensitiveDFGPass to handle multiple declarations and references in the variable of ComprehensionExpressions. To enhance the readability, the logic is moved to an own function.

Fixes #1957, #2017

Blocked by #2019

Copy link

codecov bot commented Jan 31, 2025

Codecov Report

Attention: Patch coverage is 57.14286% with 9 lines in your changes missing coverage. Please review.

Project coverage is 78.03%. Comparing base (3a7107a) to head (0f679a3).

Files with missing lines Patch % Lines
...er/aisec/cpg/passes/ControlFlowSensitiveDFGPass.kt 57.14% 7 Missing and 2 partials ⚠️

❌ Your patch check has failed because the patch coverage (57.14%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
Files with missing lines Coverage Δ
...er/aisec/cpg/passes/ControlFlowSensitiveDFGPass.kt 78.42% <57.14%> (-1.72%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KuechA KuechA marked this pull request as ready for review January 31, 2025 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant