Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow through overlay #2074

Draft
wants to merge 23 commits into
base: main
Choose a base branch
from
Draft

Follow through overlay #2074

wants to merge 23 commits into from

Conversation

KuechA
Copy link
Contributor

@KuechA KuechA commented Feb 25, 2025

Experimenting how to make the concept presented in #1994 work with the Query API and DFG/EOG extensions. Currently, this doesn't work and will likely terminate early or not traverse the overlay graph.

Options tried:

  • prefer going through the overlay graph (if possible) and skip one step when leaving it. Problematic if it doesn't leave the overlay graph again through a loop.

Somehow, doesn't work in all cases and I have no idea why. Thus, no meaningful query will work right now, see #2078

@KuechA KuechA added publish-to-github-packages If added to a PR, builds from it will be published as a GitHub package DFG labels Feb 25, 2025
Copy link

codecov bot commented Feb 25, 2025

Codecov Report

Attention: Patch coverage is 84.26966% with 14 lines in your changes missing coverage. Please review.

Project coverage is 78.56%. Comparing base (01e5915) to head (f49782c).

Files with missing lines Patch % Lines
...kotlin/de/fraunhofer/aisec/cpg/graph/Extensions.kt 63.63% 6 Missing and 6 partials ⚠️
...raunhofer/aisec/cpg/graph/AnalysisConfiguration.kt 95.12% 2 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
...rc/main/kotlin/de/fraunhofer/aisec/codyze/Sarif.kt 74.07% <100.00%> (+0.99%) ⬆️
...otlin/de/fraunhofer/aisec/cpg/query/FlowQueries.kt 96.34% <100.00%> (+0.63%) ⬆️
...aisec/cpg/graph/concepts/logging/LoggingBuilder.kt 100.00% <100.00%> (ø)
...raunhofer/aisec/cpg/graph/AnalysisConfiguration.kt 85.94% <95.12%> (+3.88%) ⬆️
...kotlin/de/fraunhofer/aisec/cpg/graph/Extensions.kt 55.98% <63.63%> (+0.01%) ⬆️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KuechA KuechA marked this pull request as ready for review March 3, 2025 08:38
@KuechA KuechA removed the publish-to-github-packages If added to a PR, builds from it will be published as a GitHub package label Mar 3, 2025
@KuechA KuechA added the publish-to-github-packages If added to a PR, builds from it will be published as a GitHub package label Mar 3, 2025
@KuechA KuechA requested a review from fwendland as a code owner March 3, 2025 14:15
@KuechA KuechA marked this pull request as draft March 3, 2025 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DFG publish-to-github-packages If added to a PR, builds from it will be published as a GitHub package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants