-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New ConceptPass
based on tasks
#2096
Draft
oxisto
wants to merge
4
commits into
main
Choose a base branch
from
concept-eog-pass
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of the whole config This makes the API a little bit cleaner since we do not need to pass the conf object, which is already known and it attaches the operations to their respective counterparts, e.g. reading an option is an operation on an option now and not of the overall configuraton. It also introduces `allOps` as a way to get all the operations of the whole config again.
Reverting this back to draft since this needs more work and possibly the split between a concept and operation pass. I will prepare a separate PR for the "Task" stuff. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a
Task
, which is a granular sub-functionality within a certainPass
. The idea is that big passes, such as the one dealing with concepts can divide their work into small sub-items, while still only iterating through the graph once.In case of the
ConceptPass
this allows us to traverse the whole graph via EOG and perform different concept-related things "in-place" where they should happen. This now should make it possible to do things like, read a config, provide dynamic loading based on the config and then read a config again in a later EOG path. This was not possible with the previous approach where load config and dynamic loading where distinct passes that could only be performed once.This PR might be too big to merge-in at once, so this could possibly be split up in multiple pieces:
Task
and adjusting the ordering helper could be split off