Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify fastmap version in DESCRIPTION #61

Merged
merged 2 commits into from
Sep 6, 2024
Merged

Specify fastmap version in DESCRIPTION #61

merged 2 commits into from
Sep 6, 2024

Conversation

kweav
Copy link
Collaborator

@kweav kweav commented Aug 26, 2024

Description

Due to the issue observed when testing new data from Sita, needed to specify the version of fastmap in the DESCRIPTION file to be a specific min version. Used the usethis package, specifically use_package("fastmap", min_version = "1.2.0") to append this to the imports section of the DESCRIPTION file.

Fixes #54

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

In the branch with this change, I used devtools::load_all() and ran the .Rmd where I originally observed the error and it ran without error, producing an output report this time.

@kweav kweav requested a review from cansavvy August 26, 2024 22:15
Copy link
Collaborator

@cansavvy cansavvy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix @kweav !

@cansavvy cansavvy merged commit 588b580 into main Sep 6, 2024
4 of 7 checks passed
@cansavvy cansavvy deleted the fastmapVersion branch September 6, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error message while running QC on new data from Sita
2 participants