Conversation
This adds some basic structured tracing on the client. This is useful both larger applications, in which case you can use a structured tracing format like opentelemetry to create structured spans with timing info, contextualized logs, etc. It also serves as more detailed debug logging on simpler clients, which can help with debugging.
oroulet
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds some basic structured tracing on the client. This is useful both larger applications, in which case you can use a structured tracing format like opentelemetry to create structured spans with timing info, contextualized logs, etc.
It also serves as more detailed debug logging on simpler clients, which can help with debugging.
Diff looks pretty fat, but it really is just adding spans and making sure to enter/exit them as appropriate. We need to avoid being in spans across await points, so that adds some nesting in a few places.