Add Playlist Sort By Video Duration

[Hoverth]

Add Playlist Sort By Video Duration

Pull Request Type

• Bugfix
• Feature Implementation
• Documentation
• Other

Related issue

Closes: #5268

Description

Closes issue #5268 and PR #5423. It works off what @creotove put in their PR, but also includes a small notification if there is a video in the playlist that does not have a time attached to it.

[Hoverth]

Odd. Now it is not displaying the toast message at all

[Hoverth]

Alright that should fix the issue.

[PikachuEXE]

Works fine so far except I think the notice should be shown also when changing sort order in single playlist view (unless already shown
This is what I have in mind
(A) (already handled)

• Enter any single playlist
• Show notice if last used sorting based on length

(B)

• Enter any single playlist, last used sorting NOT based on length
• Switch sort order to based on length
• Show notice (just once within the same view)

[Hoverth]

7143e62 moves the call to when the playlist items are sorted, so if you load a playlist and then change the sorting, it'll still show.

This means (A) and most of (B) are handled.

I'm not terribly sure how to make it only fire once though. Thoughts?

[Hoverth]

Alright, I've given single-firing only a shot, and also tweaked the time to be only 5 seconds, as 10 seemed a little long to me

[Hoverth]

@absidue it still has to iterate through all the playlist items, but this way it'll only do it if it's needed and seems to fix all the issues raised. I'm not terribly sure how performant it is as of yet, as I'm not sure of a way to test large playlists.

[PikachuEXE]

I think When the timestamp of an short is known it doesnt sort them properly should be solved by updating the entry on playlist when no valid duration saved instead of reading from history every time

Out of scope for this PR anyway

[Hoverth]

I think When the timestamp of an short is known it doesnt sort them properly should be solved by updating the entry on playlist when no valid duration saved instead of reading from history every time

Also, it would probably be good to do the same for videos fetched via RSS, but yeah that's out of scope for this PR.

[absidue]

Is there any functional reason for doing it with the subscriptions or just a nice to have?

We previously never had a need to modify the entries because the duration was a purely visual thing, so overlaying it from the watch history was fine. It's only become a problem now that you are building functionality on top of it, which as far as I can tell has nothing to do with the subscriptions...

The reason I'm asking is that if we do have to modify all the subscription cache entries, that would prevent us from switching the videos and live caches to shallowReactive once we switch to Vue 3 and Pinia, because your suggested change would require them to stay deeply reactive. Same with the playlists really and it's even worse there because they are known to have serious performance problems.

[Hoverth]

If you add a video from the subscriptions page, and it has been fetched via RSS, it would be sorted with the value '0:00', which is incorrect (impacting the functionality). You probably wouldn't have to modify the subscriptions cache, most likely just the playlists one, as they get updated when new metadata is available, whereas I don't think the same would be needed for the subscriptions page.

Basically, I foresee two approaches: update the metadata when watching the video, which would require checking each playlist every time you watch a video, or updating the metadata from history when interacting with a playlist.

[absidue]

The main problem I have with having to update the durations in the playlist is that we'll have to do it every time a video is watched and there is no way to do it quickly, because it will require going through every single video in every single playlist every time and then also doing the database updates. And a large part of the reason it will be slow is because the playlists are currently deeply reactive and they will have to stay that way if we want to do those modifications to the individual playlist items.

Although as long as we make sure that that doesn't impact the actual watch history updates, so doing it in a two step process, updating the watch history first and the metadata updates afterwards, it should be okay.

[Hoverth]

Although as long as we make sure that that doesn't impact the actual watch history updates, so doing it in a two step process, updating the watch history first and the metadata updates afterwards, it should be okay.

As that's what I've got working now, that's all good with me. One thing I would suggest, is maybe a button that reloads the metadata for all videos in a playlist? That way you don't care how long it takes, as it's an action invoked by the user themselves.

[absidue]

Although as long as we make sure that that doesn't impact the actual watch history updates, so doing it in a two step process, updating the watch history first and the metadata updates afterwards, it should be okay.

As that's what I've got working now, that's all good with me. One thing I would suggest, is maybe a button that reloads the metadata for all videos in a playlist? That way you don't care how long it takes, as it's an action invoked by the user themselves.

@Hoverth That might be misleading for the user as they might be expecting it to fetch everything from YouTube, when it would actually be updating based on the watch history. Fetching loads of data unnecessarily from YouTube is the last thing we would want to do.

[efb4f5ff-1298-471a-8973-3d47447115dc]

Weird idea and not sure if feasible but what about using the toast message for this purpose. Message would need to be slightly modified but if we add something like this to the toast Timestamp information could be fetched from other places of the application. Click here to try to fetch the missing timestamps. This can take a while.

[Hoverth]

@absidue That's fair enough. Is there any other issues with this PR?

[PikachuEXE]

Only method with side effects should be named after the action