Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Playlist Sort By Video Duration #5627

Merged
merged 16 commits into from
Oct 11, 2024
Merged

Add Playlist Sort By Video Duration #5627

merged 16 commits into from
Oct 11, 2024

Commits on Sep 26, 2024

  1. feat: bring up to date to fix merge issues

    @Hoverth
    Hoverth committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    4fe696b View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2024

  1. feat: declare alreadyShownNotice property

    @Hoverth
    Hoverth committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    959c66f View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2024

  1. refactor: change VideoLength to VideoDuration

    @Hoverth
    Hoverth committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    1508cc9 View commit details
    Browse the repository at this point in the history

  2. refactor: update translations to also use duration

    @Hoverth
    Hoverth committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    403d810 View commit details
    Browse the repository at this point in the history

  3. refactor: update SORT_BY_VALUES to also use duration

    @Hoverth
    Hoverth committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    e0a72df View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2024

  1. refactor: deduplicate repeated code into seperate function

    @Hoverth
    Hoverth committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    521c5a3 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2024

  1. feat: if the duration is missing, try and grab it from the history cache

    @Hoverth
    Hoverth committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    5714ebb View commit details
    Browse the repository at this point in the history

  2. fix: if the lengthSeconds is a string, treat it as zero (fix for RSS)

    @Hoverth
    Hoverth committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    3c73483 View commit details
    Browse the repository at this point in the history

  3. refactor: make checking the duration of a video use the same helper f… 

    …unction everywhere
    @Hoverth
    Hoverth committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    c903044 View commit details
    Browse the repository at this point in the history

  4. fix/refactor: make sure toast only shows when a item is missing a dur… 

    …ation/use a foreach loop to check the videos in a playlist
    @Hoverth
    Hoverth committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    aebeb44 View commit details
    Browse the repository at this point in the history

  5. feat: apply suggestions from code review 

    Co-authored-by: PikachuEXE <git@pikachuexe.net>
    @Hoverth @PikachuEXE
    Hoverth and PikachuEXE authored Sep 30, 2024
    Configuration menu
    Copy the full SHA
    0613bbf View commit details
    Browse the repository at this point in the history

  6. fix: make lint test pass

    @Hoverth
    Hoverth committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    8930710 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2024

  1. feat: apply suggestions from code review (use a single loop instead) 

    Co-authored-by: PikachuEXE <git@pikachuexe.net>
    @Hoverth @PikachuEXE
    Hoverth and PikachuEXE authored Oct 2, 2024
    Configuration menu
    Copy the full SHA
    38ba927 View commit details
    Browse the repository at this point in the history

  2. fix: make lint test pass for single-loop

    @Hoverth
    Hoverth committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    e630b53 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2024

  1. fix: check for present video duration in history (with small refactor… 

    …ing)
    @Hoverth
    Hoverth committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    7f140e2 View commit details
    Browse the repository at this point in the history

  2. fix: if fallback value gotten from history, still mark as missing dur… 

    …ation
    @Hoverth
    Hoverth committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    a78428e View commit details
    Browse the repository at this point in the history