Fix watch page breaking when subscriber count is missing #3794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absidue
requested review from
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc,
ChunkyProgrammer and
MarmadileManteater
github-actions
bot
added
the
PR: waiting for review
|
https://youtu.be/pcWRMvNufA video is unavailable I have no idea how to find topic channels myself (I don't really use YT besides FT) |
|
@PikachuEXE Sorry had a typo in the URL, should work now. |
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Jul 20, 2023
PikachuEXE
approved these changes
Jul 21, 2023
ChunkyProgrammer
approved these changes
Jul 21, 2023
github-actions
bot
removed
the
PR: waiting for review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix watch page breaking when subscriber count is missing
Pull Request Type
Description
YouTube is removing subscriber counts for auto-generated channels like the topic ones. Currently the watch page always expects there to be a subscriber count with the local API
Testing
(Invidious returning 403s for the music streams when proxying is disabled is a separate issue, guessing youtube doesn't like the IP of the machine requesting the watch page and the machine requesting the streams being different for music videos)
topic channel video: https://youtu.be/ipcWRMvNufA
LTT video: https://youtu.be/0EtgwIajVqs