local API: Add support for PageHeader channel header #3871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
PR: waiting for review
absidue
requested review from
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc,
ChunkyProgrammer and
MarmadileManteater
|
Only see header, expected? |
|
Yes, we would need to add special handling for them, as they only have a channel home page, so sections who's only identifying characteristic is the localised title. |
ChunkyProgrammer
approved these changes
Aug 14, 2023
PikachuEXE
approved these changes
Aug 14, 2023
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Aug 15, 2023
github-actions
bot
removed
the
PR: waiting for review
1 task
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Aug 21, 2023
* development: Translated using Weblate (Greek) Fix locales getting unnecessarily reprocessed for incremental builds (FreeTubeApp#3893) Fix the layout of the hashtag page (FreeTubeApp#3886) Translated using Weblate (French) Translated using Weblate (Swedish) Translated using Weblate (Indonesian) Translated using Weblate (Italian) Translated using Weblate (Portuguese (Brazil)) Translated using Weblate (Italian) Translated using Weblate (Portuguese) Cleanup some template conditionals (FreeTubeApp#3888) Add semantic roles to make the site more accessible (FreeTubeApp#3887) Translated using Weblate (Japanese) Fix Update Subscription Details function when channel name is null (FreeTubeApp#3884) Translated using Weblate (Spanish) Translated using Weblate (Romanian) Translated using Weblate (Hebrew) local API: Add support for PageHeader channel header (FreeTubeApp#3871) Translated using Weblate (Chinese (Traditional)) # Conflicts: # src/renderer/components/ft-list-playlist/ft-list-playlist.vue # src/renderer/components/ft-list-video/ft-list-video.vue # src/renderer/views/UserPlaylists/UserPlaylists.vue
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Aug 21, 2023
* feature/playlist-2023-05: Translated using Weblate (Greek) Fix locales getting unnecessarily reprocessed for incremental builds (FreeTubeApp#3893) Fix the layout of the hashtag page (FreeTubeApp#3886) Translated using Weblate (French) Translated using Weblate (Swedish) Translated using Weblate (Indonesian) Translated using Weblate (Italian) Translated using Weblate (Portuguese (Brazil)) Translated using Weblate (Italian) Translated using Weblate (Portuguese) Cleanup some template conditionals (FreeTubeApp#3888) Add semantic roles to make the site more accessible (FreeTubeApp#3887) Translated using Weblate (Japanese) Fix Update Subscription Details function when channel name is null (FreeTubeApp#3884) Translated using Weblate (Spanish) Translated using Weblate (Romanian) Translated using Weblate (Hebrew) local API: Add support for PageHeader channel header (FreeTubeApp#3871) ! Fix invalid prop type warning Translated using Weblate (Chinese (Traditional))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
local API: Add support for PageHeader channel header
Pull Request Type
Related issue
LuanRT/YouTube.js#450
Description
YouTube is currently A/B testing a new channel header on the auto-generated live and gaming channels, this pull request add support for them in the local API (my PR for it was released with YouTube.js 5.7.0, so it's already supported in the YouTube.js version we are using).
Testing
As per usual with YouTube's A/B tests, they are tied to the visitor id, so they can be made to show up consistently by using visitor data with a visitor id, that got included in the A/B test.
Add this line to
createInnertube()inInnertube.create()insrc/renderer/helpers/api/local.js:YouTube Gaming: https://www.youtube.com/channel/UCOpNcN46UbXVtpKMrmU4Abg
YouTube Live: https://www.youtube.com/channel/UC4R8DWoMoI7CAwX8_LjQHig