local API: Support Post Live DVR videos #3872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absidue
requested review from
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc,
ChunkyProgrammer and
MarmadileManteater
github-actions
bot
added
the
PR: waiting for review
ChunkyProgrammer
approved these changes
Aug 14, 2023
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Aug 14, 2023
github-actions
bot
removed
the
PR: waiting for review
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Aug 15, 2023
* feature/playlist-2023-05: (36 commits) ! Fix default playlists added when no playlist stored had no required attributes added on 1st run Translated using Weblate (Ukrainian) Translated using Weblate (Czech) Translated using Weblate (Hungarian) Translated using Weblate (Estonian) Translated using Weblate (Chinese (Simplified)) Translated using Weblate (Turkish) Translated using Weblate (Arabic) local API: Support Post Live DVR videos (FreeTubeApp#3872) Make profiles keyboard accessible (FreeTubeApp#3863) Bump @babel/preset-env from 7.22.9 to 7.22.10 (FreeTubeApp#3882) Bump @babel/eslint-parser from 7.22.9 to 7.22.10 (FreeTubeApp#3880) Bump eslint-plugin-vuejs-accessibility from 2.1.0 to 2.2.0 (FreeTubeApp#3883) Bump marked from 7.0.0 to 7.0.2 (FreeTubeApp#3881) Bump eslint-plugin-vue from 9.16.1 to 9.17.0 (FreeTubeApp#3879) Bump @babel/core from 7.22.9 to 7.22.10 (FreeTubeApp#3877) Bump stylelint-high-performance-animation from 1.8.0 to 1.9.0 (FreeTubeApp#3878) Bump sass from 1.64.2 to 1.65.1 (FreeTubeApp#3876) Bump eslint from 8.46.0 to 8.47.0 (FreeTubeApp#3875) Translated using Weblate (Italian) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
local API: Support Post Live DVR videos
Pull Request Type
Related issue
closes #3582
Description
Just after a live stream has ended, before it has been processed into a normal video, it is still in the live stream format of self intialising DASH segments. YouTube uses self-initialising segments for their live stream DASH, which is in the DASH spec but highly discouraged by the interoperability guidelines, so video.js doesn't support them. That's why we can't use DASH for the live streams but also means we can't use it for videos in the Post Live DVR state, instead we can treat them like currently live streams and use the provided HLS manifest.
This pull request only adds support for the local API, as Invidious doesn't tell us when a video has the
isPostLiveDvrflag set.Testing
As you might be testing this days or weeks later, any Post Live DVR videos I would link to, would have been processed into normal videos by then. Instead I made a script that will find a video in the Post Live DVR state for you, so you can test this pull request, without having to find one yourself.
.mjsnode find-post-live-dvr.mjsTry watching the video with the local API, you should be able watch and seek around, compared to previously where it would either load endlessly or show a player UI that is ended but doesn't allow you to seek back so you could watch anything.