Undo Feature For Remove From Playlist. #5885
Open
+45
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
PR: waiting for review
absidue
added
the
DO NOT MERGE UNTIL AFTER RELEASE
|
Could you please also undo the changes to the unrelated files? This time please do it in this pull request instead of closing and creating a duplicate one. |
absidue
reviewed
Oct 22, 2024
| @@ -129,11 +129,10 @@ function moveVideoDown(videoId, playlistItemId) { | |||
| } | |||
|
|
|||
| /** | |||
| * @param {string} videoId | |||
| * @param {string} playlistItemId | |||
| * @param {string} result | |||
There was a problem hiding this comment.
Suggested change
| * @param {string} result | |
| * @param {any} video |
Comment on lines
134
to
135
| function removeFromPlaylist(result) { | ||
| emit('remove-from-playlist', result) |
There was a problem hiding this comment.
Suggested change
| function removeFromPlaylist(result) { | |
| emit('remove-from-playlist', result) | |
| function removeFromPlaylist(video) { | |
| emit('remove-from-playlist', video) |
efb4f5ff-1298-471a-8973-3d47447115dc
added
PR: changes requested
and removed
PR: waiting for review
absidue
added
DO NOT MERGE UNTIL AFTER RELEASE
auto-merge was automatically disabled
October 27, 2024 15:00
Head branch was pushed to by a user without write access
ChunkyProgrammer
added
PR: waiting for review
ChunkyProgrammer
requested review from
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc,
ChunkyProgrammer and
kommunarr
PikachuEXE
requested changes
Nov 3, 2024
There was a problem hiding this comment.
We already have a file telling editor to use spaces instead of tabs for indent
https://github.com/FreeTubeApp/FreeTube/blob/development/.editorconfig
Please setup your editor (info at https://editorconfig.org) and fix those tabs
Comment on lines
600
to
616
| this.removeVideo({ | ||
| _id: this.playlistId, | ||
| videoId: videoData.videoId, | ||
| playlistItemId: videoData.playlistItemId, | ||
| }) | ||
|
|
||
| // Update playlist's `lastUpdatedAt` | ||
| this.updatePlaylist({ _id: this.playlistId }) | ||
| showToast(this.$t('User Playlists.SinglePlaylistView.Toast["Video has been removed. Click here to undo."]'), 3000, () => { | ||
| this.addVideoBackToPlaylist(videoData); | ||
| } | ||
| ); | ||
| } catch (e) { | ||
| showToast(this.$t('User Playlists.SinglePlaylistView.Toast.There was a problem with removing this video')) | ||
| console.error(e) | ||
| } | ||
|
|
There was a problem hiding this comment.
these
Also remove the last blank line before the end of method?
| showToast(this.$t('User Playlists.SinglePlaylistView.Toast.There was a problem with removing this video')) | ||
| console.error(e) | ||
| showToast(this.$t('User Playlists.SinglePlaylistView.Toast.There was a problem with adding this video back to playlist')); | ||
| console.error(e); |
There was a problem hiding this comment.
Please remove unnecessary semicolons
absidue
added
PR: changes requested
and removed
PR: waiting for review
auto-merge was automatically disabled
November 16, 2024 11:47
Head branch was pushed to by a user without write access
auto-merge was automatically disabled
November 16, 2024 12:21
Head branch was pushed to by a user without write access
PikachuEXE
requested changes
Nov 17, 2024
auto-merge was automatically disabled
November 17, 2024 12:47
Head branch was pushed to by a user without write access
efb4f5ff-1298-471a-8973-3d47447115dc
requested changes
Nov 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Related issue
closes #5421
Additional context
resolved yarn.lock conflict