-
Notifications
You must be signed in to change notification settings - Fork 841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Big Play Button
smaller
#6002
base: development
Are you sure you want to change the base?
Make Big Play Button
smaller
#6002
Conversation
Maybe unrelated but what were the dimensions of the pre v0.22.0 button? |
For reference, our pre-Shaka play button opacity was 0.45: |
It's also worth noting that YT does not have this feature on either web or their mobile app. Maybe we change the default setting? Fine for keeping that discussion & implementation to a separate one-line PR if desired, though |
Oh default value is on? |
By default in shaka-player, the big play button only appears for mobile users. I'm okay with changing the default to off. @MarmadileManteater you may want to keep it on for FreeTubeAndroid. |
@kommunarr I'm slightly confused what you mean by YouTube's mobile app doesn't have this, because from what I can tell it definitely does: |
src/renderer/components/ft-shaka-video-player/ft-shaka-video-player.css
Outdated
Show resolved
Hide resolved
@absidue On second check, you're correct, it does have it, but the overlay dismisses itself on clicking the player. My mistake |
non-blocking: I'd like to see what it would look like at the v0.21 0.45 opacity |
I prefer the lower opacity just because it only really matters if it's visible at all versus not. Will go with whichever one the team prefers. |
Ask #5951 guys? |
ef8087e
to
a137eec
Compare
Make
Big Play Button
smallerPull Request Type
Related issue
closes #5951
Description
This PR adds some transparency to the Big Play Button and adds a max size for it (110px x 110px).
Screenshots (from 22 inch monitor)
Before:
Normal mode:
Theater Mode:
After:
Normal mode:
Theater mode (the button is the same size but it might look smaller on GitHub since the screenshot is larger):
Testing
Desktop