Fix context menu adding video scroll bar #6075
Merged
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tside player container Horizontal overflow is already being hidden to fix an issue returning from fullscreen. This commit makes it so vertical overflow is hidden too in case the context menu is made visible but reaches outside the video player container.
github-actions
bot
added
the
PR: waiting for review
efb4f5ff-1298-471a-8973-3d47447115dc
requested review from
PikachuEXE,
absidue,
ChunkyProgrammer and
kommunarr
kommunarr
approved these changes
Nov 3, 2024
absidue
approved these changes
Nov 3, 2024
github-actions
bot
removed
the
PR: waiting for review
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Nov 4, 2024
* development: (153 commits) Migrate FtTimestampCatcher to the composition API (FreeTubeApp#6064) Translated using Weblate (Polish) Added functionality to export a single playlist (FreeTubeApp#5779) Fix video player displaying a vertical scrollbar when context menu outside player container (FreeTubeApp#6075) Fix use of deprecated Invidious route on the videos subscription tab (FreeTubeApp#6057) Apply active FreeTube theme to shaka-player menus (FreeTubeApp#5986) Bump sass from 1.80.4 to 1.80.6 (FreeTubeApp#6071) Bump mini-css-extract-plugin from 2.9.1 to 2.9.2 (FreeTubeApp#6068) Translated using Weblate (Vietnamese) Bump webpack from 5.95.0 to 5.96.1 (FreeTubeApp#6069) Translated using Weblate (Vietnamese) Bump sass-loader from 16.0.2 to 16.0.3 (FreeTubeApp#6070) Bump lefthook from 1.8.1 to 1.8.2 (FreeTubeApp#6067) Bump the eslint group with 2 updates (FreeTubeApp#6066) Bump youtubei.js from 11.0.0 to 11.0.1 (FreeTubeApp#6072) Migrate PasswordSettings and PasswordDialog to the composition API (FreeTubeApp#6036) Add some missing jsdoc comments, add jsdoc eslint plugin (FreeTubeApp#6048) Fix shortcut for macOS setting shortcut in video page (FreeTubeApp#6054) Use decodingInfo's powerEfficient property when picking streams (FreeTubeApp#6061) Translated using Weblate (Afrikaans) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix video player displaying a vertical scrollbar when context menu outside player container
Pull Request Type
Related issue
Closes #6006
Description
Hey, I've been interested in extra features but before taming the beast, I figured I'd just try something easy first.
So turns out with the recent update to the video player to use the shaka player, when the context menu is brought too close to the bottom, it adds a scroll bar to the video container.
This PR just aims to make both horizontal and vertical
overflowcss properties of the video player component tohiddenrather than just the horizontal part.Screenshots
Testing
This was tested, and indeed closes #6006.
Desktop
Additional context
So, I initially wanted to re-position the context menu slightly higher or to the left if it were to be respectively too close to the bottom or to the right ends. I naively thought I could replace the "contextmenu" event listener but spending hours on this just pointed me to ugly hacks at best so I didn't carry on.
For reference, the context menu div position callback is defined in the
Shaka.ui.ContextMenuconstructorShaka player docs: https://shaka-player-demo.appspot.com/docs/api/ui_context_menu.js.html#line48
Shaka player code: https://github.com/shaka-project/shaka-player/blob/main/ui/context_menu.js#L48
I'm not gonna try fixing that upstream, but if anyone has any idea, I'm all hears.
Alternatively, we could
overflowcss property tovisibleso the context menu will always be visible, and no scrollbar, but requires additional testing going in and out fullscreen;