Rename custom ESLint rule to prefer-use-i18n-polyfill #6120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absidue
requested review from
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc,
ChunkyProgrammer,
kommunarr and
MarmadileManteater
github-actions
bot
added
the
PR: waiting for review
kommunarr
approved these changes
Nov 8, 2024
ChunkyProgrammer
approved these changes
Nov 9, 2024
PikachuEXE
approved these changes
Nov 10, 2024
github-actions
bot
removed
the
PR: waiting for review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename custom ESLint rule to prefer-use-i18n-polyfill
Pull Request Type
Description
I picked a bad name for the ESLint rule and now it appears in the auto-complete suggestions every time you type
useI18n, if you have a typo VSCode even prioritises it over the polyfill. This pull request fixes that by renaming the rule toprefer-use-i18n-polyfill.Screenshots
Testing
If the linting workflow in this PR suceeds then it works, you can also run the linting yourself locally if you don't trust GitHub actions:
yarn eslint-lint.Desktop