Skip to content

Commit

Permalink
clarify Certificate Source descriptions
Browse files Browse the repository at this point in the history
  • Loading branch information
mateusz.wojtania committed Dec 30, 2024
1 parent d0d4a09 commit a822bfb
Show file tree
Hide file tree
Showing 15 changed files with 60 additions and 20 deletions.
4 changes: 4 additions & 0 deletions Frends.HTTP.DownloadFile/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Changelog

## [1.0.1] - 2024-12-30
### Changed
- Descriptions of ClientCertificate suboptions includes clearer information about usage in terms of different types of ClientCertificate.

## [1.0.0] - 2023-01-27
### Added
- Initial implementation.
Original file line number Diff line number Diff line change
Expand Up @@ -47,30 +47,34 @@ public class Options
public CertificateSource ClientCertificateSource { get; set; }

/// <summary>
/// Path to the Client Certificate when using a file as the Certificate Source, pfx (pkcs12) files are recommended. For other supported formats, see
/// Applicable only when Certificate Source is "File".
/// Path to the Client Certificate, pfx (pkcs12) files are recommended. For other supported formats, see
/// https://docs.microsoft.com/en-us/dotnet/api/system.security.cryptography.x509certificates.x509certificate2collection.import?view=netframework-4.7.1
/// </summary>
/// <example>domain\path</example>
[UIHint(nameof(Authentication), "", Authentication.ClientCertificate)]
public string ClientCertificateFilePath { get; set; }

/// <summary>
/// Client certificate bytes as a base64 encoded string when using a string as the Certificate Source , pfx (pkcs12) format is recommended. For other supported formates, see
/// Applicable only when Certificate Source is "String".
/// Client certificate bytes as a base64 encoded string, pfx (pkcs12) format is recommended. For other supported formates, see
/// https://docs.microsoft.com/en-us/dotnet/api/system.security.cryptography.x509certificates.x509certificate2collection.import?view=netframework-4.7.1
/// </summary>
/// <example>domain\path</example>
[UIHint(nameof(Authentication), "", Authentication.ClientCertificate)]
public string ClientCertificateInBase64 { get; set; }

/// <summary>
/// Key phrase (password) to access the certificate data when using a string or file as the Certificate Source
/// Applicable only when Certificate Source is "File" or "String".
/// Key phrase (password) to access the certificate data
/// </summary>
/// <example>string value</example>
[PasswordPropertyText]
[UIHint(nameof(Authentication), "", Authentication.ClientCertificate)]
public string ClientCertificateKeyPhrase { get; set; }

/// <summary>
/// Applicable only when Certificate Source is "CertificateStore".
/// Thumbprint for using client certificate authentication.
/// </summary>
/// <example>thumbprint</example>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

<PropertyGroup>
<TargetFrameworks>net6.0</TargetFrameworks>
<Version>1.0.0</Version>
<Version>1.0.1</Version>
<Authors>Frends</Authors>
<Copyright>Frends</Copyright>
<Company>Frends</Company>
Expand Down
4 changes: 4 additions & 0 deletions Frends.HTTP.Request/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Changelog

## [1.2.1] - 2024-12-30
### Changed
- Descriptions of ClientCertificate suboptions includes clearer information about usage in terms of different types of ClientCertificate.

## [1.2.0] - 2024-08-19
### Changed
- Removed handling where only PATCH, PUT, POST and DELETE requests were allowed to have the Content-Type header and content, due to HttpClient failing if e.g., a GET request had content. HttpClient has since been updated to tolerate such requests.
Expand Down
10 changes: 7 additions & 3 deletions Frends.HTTP.Request/Frends.HTTP.Request/Definitions/Options.cs
Original file line number Diff line number Diff line change
Expand Up @@ -46,30 +46,34 @@ public class Options
public CertificateSource ClientCertificateSource { get; set; }

/// <summary>
/// Path to the Client Certificate when using a file as the Certificate Source, pfx (pkcs12) files are recommended. For other supported formats, see
/// Applicable only when Certificate Source is "File".
/// Path to the Client Certificate, pfx (pkcs12) files are recommended. For other supported formats, see
/// https://docs.microsoft.com/en-us/dotnet/api/system.security.cryptography.x509certificates.x509certificate2collection.import?view=netframework-4.7.1
/// </summary>
/// <example>domain\path</example>
[UIHint(nameof(Authentication), "", Authentication.ClientCertificate)]
public string ClientCertificateFilePath { get; set; }

/// <summary>
/// Client certificate bytes as a base64 encoded string when using a string as the Certificate Source , pfx (pkcs12) format is recommended. For other supported formates, see
/// Applicable only when Certificate Source is "String".
/// Client certificate bytes as a base64 encoded string, pfx (pkcs12) format is recommended. For other supported formates, see
/// https://docs.microsoft.com/en-us/dotnet/api/system.security.cryptography.x509certificates.x509certificate2collection.import?view=netframework-4.7.1
/// </summary>
/// <example>domain\path</example>
[UIHint(nameof(Authentication), "", Authentication.ClientCertificate)]
public string ClientCertificateInBase64 { get; set; }

/// <summary>
/// Key phrase (password) to access the certificate data when using a string or file as the Certificate Source
/// Applicable only when Certificate Source is "File" or "String".
/// Key phrase (password) to access the certificate data
/// </summary>
/// <example>string value</example>
[PasswordPropertyText]
[UIHint(nameof(Authentication), "", Authentication.ClientCertificate)]
public string ClientCertificateKeyPhrase { get; set; }

/// <summary>
/// Applicable only when Certificate Source is "CertificateStore".
/// Thumbprint for using client certificate authentication.
/// </summary>
/// <example>thumbprint</example>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

<PropertyGroup>
<TargetFrameworks>net6.0</TargetFrameworks>
<Version>1.2.0</Version>
<Version>1.2.1</Version>
<Authors>Frends</Authors>
<Copyright>Frends</Copyright>
<Company>Frends</Company>
Expand Down
4 changes: 4 additions & 0 deletions Frends.HTTP.RequestBytes/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Changelog

## [1.0.2] - 2024-12-30
### Changed
- Descriptions of ClientCertificate suboptions includes clearer information about usage in terms of different types of ClientCertificate.

## [1.0.1] - 2024-01-17
### Fixed
- Fixed issues which CodeQL found in the codebase.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,30 +46,34 @@ public class Options
public CertificateSource ClientCertificateSource { get; set; }

/// <summary>
/// Path to the Client Certificate when using a file as the Certificate Source, pfx (pkcs12) files are recommended. For other supported formats, see
/// Applicable only when Certificate Source is "File".
/// Path to the Client Certificate, pfx (pkcs12) files are recommended. For other supported formats, see
/// https://docs.microsoft.com/en-us/dotnet/api/system.security.cryptography.x509certificates.x509certificate2collection.import?view=netframework-4.7.1
/// </summary>
/// <example>domain\path</example>
[UIHint(nameof(Authentication), "", Authentication.ClientCertificate)]
public string ClientCertificateFilePath { get; set; }

/// <summary>
/// Client certificate bytes as a base64 encoded string when using a string as the Certificate Source , pfx (pkcs12) format is recommended. For other supported formates, see
/// Applicable only when Certificate Source is "String".
/// Client certificate bytes as a base64 encoded string, pfx (pkcs12) format is recommended. For other supported formates, see
/// https://docs.microsoft.com/en-us/dotnet/api/system.security.cryptography.x509certificates.x509certificate2collection.import?view=netframework-4.7.1
/// </summary>
/// <example>domain\path</example>
[UIHint(nameof(Authentication), "", Authentication.ClientCertificate)]
public string ClientCertificateInBase64 { get; set; }

/// <summary>
/// Key phrase (password) to access the certificate data when using a string or file as the Certificate Source
/// Applicable only when Certificate Source is "File" or "String".
/// Key phrase (password) to access the certificate data
/// </summary>
/// <example>string value</example>
[PasswordPropertyText]
[UIHint(nameof(Authentication), "", Authentication.ClientCertificate)]
public string ClientCertificateKeyPhrase { get; set; }

/// <summary>
/// Applicable only when Certificate Source is "CertificateStore".
/// Thumbprint for using client certificate authentication.
/// </summary>
/// <example>thumbprint</example>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

<PropertyGroup>
<TargetFrameworks>net6.0</TargetFrameworks>
<Version>1.0.1</Version>
<Version>1.0.2</Version>
<Authors>Frends</Authors>
<Copyright>Frends</Copyright>
<Company>Frends</Company>
Expand Down
4 changes: 4 additions & 0 deletions Frends.HTTP.SendAndReceiveBytes/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Changelog

## [1.0.1] - 2024-12-30
### Changed
- Descriptions of ClientCertificate suboptions includes clearer information about usage in terms of different types of ClientCertificate.

## [1.0.0] - 2023-06-01
### Added
- Initial implementation.
Original file line number Diff line number Diff line change
Expand Up @@ -48,23 +48,26 @@ public class Options
public CertificateSource ClientCertificateSource { get; set; }

/// <summary>
/// Path to the Client Certificate when using a file as the Certificate Source, pfx (pkcs12) files are recommended. For other supported formats, see
/// Applicable only when Certificate Source is "File".
/// Path to the Client Certificate, pfx (pkcs12) files are recommended. For other supported formats, see
/// https://docs.microsoft.com/en-us/dotnet/api/system.security.cryptography.x509certificates.x509certificate2collection.import?view=netframework-4.7.1
/// </summary>
/// <example>domain\path</example>
[UIHint(nameof(Authentication), "", Authentication.ClientCertificate)]
public string ClientCertificateFilePath { get; set; }

/// <summary>
/// Client certificate bytes as a base64 encoded string when using a string as the Certificate Source , pfx (pkcs12) format is recommended. For other supported formates, see
/// Applicable only when Certificate Source is "String".
/// Client certificate bytes as a base64 encoded string, pfx (pkcs12) format is recommended. For other supported formates, see
/// https://docs.microsoft.com/en-us/dotnet/api/system.security.cryptography.x509certificates.x509certificate2collection.import?view=netframework-4.7.1
/// </summary>
/// <example>domain\path</example>
[UIHint(nameof(Authentication), "", Authentication.ClientCertificate)]
public string ClientCertificateInBase64 { get; set; }

/// <summary>
/// Key phrase (password) to access the certificate data when using a string or file as the Certificate Source
/// Applicable only when Certificate Source is "File" or "String".
/// Key phrase (password) to access the certificate data
/// </summary>
/// <example>string value</example>
[DisplayFormat(DataFormatString = "Text")]
Expand All @@ -73,6 +76,7 @@ public class Options
public string ClientCertificateKeyPhrase { get; set; }

/// <summary>
/// Applicable only when Certificate Source is "CertificateStore".
/// Thumbprint for using client certificate authentication.
/// </summary>
/// <example>thumbprint</example>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

<PropertyGroup>
<TargetFrameworks>net6.0</TargetFrameworks>
<Version>1.0.0</Version>
<Version>1.0.1</Version>
<Authors>Frends</Authors>
<Copyright>Frends</Copyright>
<Company>Frends</Company>
Expand Down
4 changes: 4 additions & 0 deletions Frends.HTTP.SendBytes/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Changelog

## [1.0.1] - 2024-12-30
### Changed
- Descriptions of ClientCertificate suboptions includes clearer information about usage in terms of different types of ClientCertificate.

## [1.0.0] - 2023-05-30
### Added
- Initial implementation.
Original file line number Diff line number Diff line change
Expand Up @@ -46,30 +46,34 @@ public class Options
public CertificateSource ClientCertificateSource { get; set; }

/// <summary>
/// Path to the Client Certificate when using a file as the Certificate Source, pfx (pkcs12) files are recommended. For other supported formats, see
/// Applicable only when Certificate Source is "File".
/// Path to the Client Certificate, pfx (pkcs12) files are recommended. For other supported formats, see
/// https://docs.microsoft.com/en-us/dotnet/api/system.security.cryptography.x509certificates.x509certificate2collection.import?view=netframework-4.7.1
/// </summary>
/// <example>domain\path</example>
[UIHint(nameof(Authentication), "", Authentication.ClientCertificate)]
public string ClientCertificateFilePath { get; set; }

/// <summary>
/// Client certificate bytes as a base64 encoded string when using a string as the Certificate Source , pfx (pkcs12) format is recommended. For other supported formates, see
/// Applicable only when Certificate Source is "String".
/// Client certificate bytes as a base64 encoded string, pfx (pkcs12) format is recommended. For other supported formates, see
/// https://docs.microsoft.com/en-us/dotnet/api/system.security.cryptography.x509certificates.x509certificate2collection.import?view=netframework-4.7.1
/// </summary>
/// <example>domain\path</example>
[UIHint(nameof(Authentication), "", Authentication.ClientCertificate)]
public string ClientCertificateInBase64 { get; set; }

/// <summary>
/// Key phrase (password) to access the certificate data when using a string or file as the Certificate Source
/// Applicable only when Certificate Source is "File" or "String".
/// Key phrase (password) to access the certificate data
/// </summary>
/// <example>string value</example>
[PasswordPropertyText]
[UIHint(nameof(Authentication), "", Authentication.ClientCertificate)]
public string ClientCertificateKeyPhrase { get; set; }

/// <summary>
/// Applicable only when Certificate Source is "CertificateStore".
/// Thumbprint for using client certificate authentication.
/// </summary>
/// <example>thumbprint</example>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

<PropertyGroup>
<TargetFrameworks>net6.0</TargetFrameworks>
<Version>1.0.0</Version>
<Version>1.0.1</Version>
<Authors>Frends</Authors>
<Copyright>Frends</Copyright>
<Company>Frends</Company>
Expand Down

0 comments on commit a822bfb

Please sign in to comment.