Do not use abbreviation in module independant inerfaces

Signed-off-by: Anton Fedurtsya <anton@fedurtsya.com>
Fresh-Advance · Oct 7, 2023 · e047119 · e047119
1 parent 702a9ba
commit e047119
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 7 deletions.
diff --git a/src/Document/MpdfDocument/Builder.php b/src/Document/MpdfDocument/Builder.php
@@ -58,10 +58,10 @@ protected function preparePdfData(InvoiceDataInterface $invoiceData): PdfData
     {
         $currentLanguage = $this->shopLanguage->getTplLanguage();
         try {
-            $this->shopLanguage->faForceSetTplLanguage((int)$invoiceData->getLanguageId());
+            $this->shopLanguage->forceSetTplLanguage((int)$invoiceData->getLanguageId());
             $html = $this->templateRenderer->renderTemplate(self::INVOICE_TEMPLATE, ['invoice' => $invoiceData]);
         } finally {
-            $this->shopLanguage->faForceSetTplLanguage((int)$currentLanguage);
+            $this->shopLanguage->forceSetTplLanguage((int)$currentLanguage);
         }
 
         return new PdfData(

diff --git a/src/Transition/Core/LanguageInterface.php b/src/Transition/Core/LanguageInterface.php
@@ -11,7 +11,7 @@
 
 interface LanguageInterface
 {
-    public function faForceSetTplLanguage(int $language): void;
+    public function forceSetTplLanguage(int $language): void;
 
     public function getTplLanguage(): int;
 }
diff --git a/src/Transition/Core/LanguageProxy.php b/src/Transition/Core/LanguageProxy.php
@@ -20,7 +20,7 @@ public function __construct(\OxidEsales\Eshop\Core\Language $language)
         $this->language = $language;
     }
 
-    public function faForceSetTplLanguage(int $language): void
+    public function forceSetTplLanguage(int $language): void
     {
         $this->language->faForceSetTplLanguage($language);
     }

diff --git a/tests/Integration/Document/MpdfDocument/BuilderTest.php b/tests/Integration/Document/MpdfDocument/BuilderTest.php
@@ -41,8 +41,8 @@ public function testGetBinaryPdfFromData(): void
             'renderTemplate' => 'someContentHtml'
         ]);
 
-        $shopLanguage = $this->createPartialMock(LanguageProxy::class, ['getTplLanguage', 'faForceSetTplLanguage']);
-        $shopLanguage->expects($this->exactly(2))->method('faForceSetTplLanguage');
+        $shopLanguage = $this->createPartialMock(LanguageProxy::class, ['getTplLanguage', 'forceSetTplLanguage']);
+        $shopLanguage->expects($this->exactly(2))->method('forceSetTplLanguage');
 
         $moduleSettings = $this->createConfiguredMock(ModuleSettings::class, [
             'getDocumentFooter' => 'someFooter'

diff --git a/tests/Integration/Transition/Core/LanguageProxyTest.php b/tests/Integration/Transition/Core/LanguageProxyTest.php
@@ -23,7 +23,7 @@ public function testForceLanguageIdSetter(): void
         $languageMock = $this->createPartialMock(Language::class, []);
 
         $sut = new LanguageProxy($languageMock);
-        $sut->faForceSetTplLanguage($languageId);
+        $sut->forceSetTplLanguage($languageId);
 
         $this->assertSame($languageId, $sut->getTplLanguage());
     }