refactor(config): Prototype of config separation and auto loading #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Plakhotnikov Vladimir <v.plahotnikov@yclients.tech>
Kaspiman
commented
Jan 4, 2025
| ); | ||
|
|
||
| if ($instrumentation['tracing']['enabled']) { | ||
| $loader->load('instrumentation/'.$name.'.php'); |
|
Hi @Kaspiman, thanks again for working on this. I know this is one of the last steps before reaching the alpha milestone but I am not sure how I'd like to implement this. It should solve the issues #63 and #64. I think I would like use compiler passes to declare services definitions based on specific conditions/specifications. I started this work in #107, would you mind to take a look and tell me what you think? |
|
@gaelreyrol Your solution looks good to me, let's merge it! |
|
Closing in favor of #107. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Services for different modules and packages are loaded only when needed. You can set tags for services and not remove them later. The container will not contain unnecessary services. You can take this idea further and include files automatically based on installed packages. @gaelreyrol