Support handling of rector fatal errors (#111)

FriendsOfREDAXO · Aug 13, 2023 · 16309c5 · 16309c5
1 parent 1622e1d
commit 16309c5
Show file tree

Hide file tree

Showing 4 changed files with 32 additions and 0 deletions.
diff --git a/lib/CsFixerResult.php b/lib/CsFixerResult.php
@@ -51,4 +51,11 @@ public function getFileDiffs(): array
         }
         return $fileDiffs;
     }
+
+    /**
+     * @return list<string>
+     */
+    public function getFatalErrors(): array {
+        return [];
+    }
 }
diff --git a/lib/RectorResult.php b/lib/RectorResult.php
@@ -71,4 +71,11 @@ public function getAppliedRectors(): array
 
         return array_unique($rectors);
     }
+
+    /**
+     * @return list<string>
+     */
+    public function getFatalErrors(): array {
+        return $this->json['fatal_errors'] ?? [];
+    }
 }
diff --git a/pages/apply.php b/pages/apply.php
@@ -24,6 +24,15 @@
 
 $result = RexFactor::runRexFactor($addon, $setList, $targetVersion, false, $skipList->toRectorSkipList());
 
+$fatalErrors = $result->getFatalErrors();
+if ($fatalErrors !== []) {
+    foreach($fatalErrors as $error) {
+        echo rex_view::error($error);
+    }
+
+    return;
+}
+
 $total = $result->getTotals();
 $content = '';
 if ($total['changed_files'] > 0) {

diff --git a/pages/preview.php b/pages/preview.php
@@ -52,6 +52,15 @@
 
 $result = RexFactor::runRexFactor($addon, $setList, $targetVersion, true, $skipList->toRectorSkipList());
 
+$fatalErrors = $result->getFatalErrors();
+if ($fatalErrors !== []) {
+    foreach($fatalErrors as $error) {
+        echo rex_view::error($error);
+    }
+
+    return;
+}
+
 $html = $content = $diffout = '';
 $total = $result->getTotals();
 if ($total['changed_files'] > 0) {