Skip to content

feat: migrate config xml => php #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: 2.x
Choose a base branch
from
Open

feat: migrate config xml => php #274

wants to merge 4 commits into from

Conversation

@Chris53897
Copy link
Contributor

@Chris53897 Chris53897 commented Nov 7, 2025 •
edited
Loading

@mbabker
Copy link
Contributor

mbabker commented Nov 20, 2025

i am not sure, how to rewrite https://github.com/FriendsOfSymfony/FOSCKEditorBundle/blob/2.x/src/Resources/config/renderer.xml#L14C65-L14C71

IIRC it's something like expr("container.hasParameter('locale') ? parameter('locale') : null")

@Chris53897
Copy link
Contributor Author

Chris53897 commented Nov 20, 2025

thanks @mbabker
The CI is green with your suggestion and with NULL.
So i can not be 100% sure if it is correct.

GromNaN
GromNaN approved these changes Nov 20, 2025
View reviewed changes
Copy link

@GromNaN GromNaN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The expression is correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@GromNaN GromNaN GromNaN approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Chris53897 @mbabker @GromNaN @Chris8934