Merge pull request #586 from FriendsOfSymfony/use-tag-header-parser

use tag header parser
FriendsOfSymfony · Dec 1, 2022 · be22ba1 · be22ba1
2 parents 9c93836 + a6d07c5
commit be22ba1
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,6 +1,12 @@
 Changelog
 =========
 
+2.14.0
+------
+
+* Fix handling of custom glue for response tags. If you use custom glue with the Symfony HttpCache,
+  you can now configure a customized tag header parser on the `PurgeTagsListener`.
+
 2.13.0
 ------
 

diff --git a/composer.json b/composer.json
@@ -22,7 +22,7 @@
     ],
     "require": {
         "php": "^7.3 || ^8.0",
-        "friendsofsymfony/http-cache": "^2.6",
+        "friendsofsymfony/http-cache": "^2.15",
         "symfony/framework-bundle": "^4.4.0 || ^5.0 || ^6.0",
         "symfony/http-foundation": "^4.4.0 || ^5.0 || ^6.0",
         "symfony/http-kernel": "^4.4.0 || ^5.0 || ^6.0"

diff --git a/src/Http/SymfonyResponseTagger.php b/src/Http/SymfonyResponseTagger.php
@@ -34,7 +34,7 @@ public function tagSymfonyResponse(Response $response, $replace = false)
         if (!$replace && $response->headers->has($this->getTagsHeaderName())) {
             $header = $response->headers->get($this->getTagsHeaderName());
             if ('' !== $header) {
-                $this->addTags(explode(',', $response->headers->get($this->getTagsHeaderName())));
+                $this->addTags($this->parseTagsHeaderValue($response->headers->get($this->getTagsHeaderName())));
             }
         }