fix explicit type declarations

aether-core/aether/client/src/app/mainmain.ts

@@ -74,7 +74,7 @@ function startAutoUpdateCheck() {
 // be closed automatically when the JavaScript object is garbage collected.
 let win: any
 let tray: any = null
-var DOM_READY: boolean = false
+var DOM_READY = false
 
 // Fix for enabling Windows notifications.
 if (process.platform === 'win32') {

aether-core/aether/client/src/app/services/feapiconsumer/feapiconsumer.ts

@@ -23,8 +23,8 @@ var proto = require('../../../../../protos/feapi/feapi_grpc_pb')
 
 let feAPIConsumer: any
 let Initialised: boolean
-let initInProgress: boolean = false
-let clientApiServerPortIsSet: boolean = false
+let initInProgress = false
+let clientApiServerPortIsSet = false
 
 function timeout(ms: any) {
   return new Promise(function (resolve) {

aether-core/aether/client/src/app/services/fesupervisor/fesupervisor.ts

@@ -5,7 +5,7 @@ export {}
 const { spawn } = require('child_process')
 const isDev = require('electron-is-dev')
 let globals = require('../globals/globals')
-let clientAPIServerIP: string = '127.0.0.1'
+let clientAPIServerIP = '127.0.0.1'
 let os = require('os')
 let path = require('path')
 

aether-core/aether/client/src/app/store/contentrelations.ts

@@ -86,7 +86,7 @@ let actions = {
 let mutations = {
   SAVE_BOARD_SIGNAL(state: any, payload: any) {
     // Find board in the store and change the state appropriately.
-    for (var i: number = 0; i < state.allBoards.length; i++) {
+    for (var i = 0; i < state.allBoards.length; i++) {
       ;(function (i: number) {
         if (state.allBoards[i].fingerprint === payload.fp) {
           if (typeof payload.subbed !== 'undefined') {

aether-core/aether/client/src/app/store/statuslights.ts

@@ -36,7 +36,7 @@ function getTimeFromNowInMinutes(ts: number): number {
   - last refresh timestamp > 5 min
 */
 function computeRefresherDotState(ambientStatus: any): string {
-  let state: string = 'status_subsection_ok'
+  let state = 'status_subsection_ok'
   let fas = ambientStatus.frontendambientstatus
   if (getTimeFromNowInMinutes(fas.lastrefreshtimestamp) > 5) {
     console.log(
@@ -54,8 +54,8 @@ function computeRefresherDotState(ambientStatus: any): string {
   - inflights queue length > 10
 */
 function computeInflightsDotState(ambientStatus: any): string {
-  let state: string = 'status_subsection_ok'
-  let iflCount: number = 0
+  let state = 'status_subsection_ok'
+  let iflCount = 0
   iflCount = iflCount + ambientStatus.inflights.boardsList.length
   iflCount = iflCount + ambientStatus.inflights.threadsList.length
   iflCount = iflCount + ambientStatus.inflights.postsList.length
@@ -80,7 +80,7 @@ function computeInflightsDotState(ambientStatus: any): string {
   - upnp status != 'successful' or 'in progress' (actually this doesn't matter all that much so long as inbounds are coming in. NBD, let's skip this one for now.)
 */
 function computeNetworkDotState(ambientStatus: any): string {
-  let state: string = 'status_subsection_ok'
+  let state = 'status_subsection_ok'
   let bas = ambientStatus.backendambientstatus
   if (bas.inboundscount15 < 2) {
     console.log(
@@ -105,7 +105,7 @@ function computeNetworkDotState(ambientStatus: any): string {
   - lastinsertdurationseconds > 360
 */
 function computeDbDotState(ambientStatus: any): string {
-  let state: string = 'status_subsection_ok'
+  let state = 'status_subsection_ok'
   let bas = ambientStatus.backendambientstatus
   if (bas.lastinsertdurationseconds > 360) {
     console.log(
@@ -123,7 +123,7 @@ function computeDbDotState(ambientStatus: any): string {
   - Last cache generation timestamp > 12 hours
 */
 function computeCachingDotState(ambientStatus: any): string {
-  let state: string = 'status_subsection_ok'
+  let state = 'status_subsection_ok'
   let bas = ambientStatus.backendambientstatus
   if (
     getTimeFromNowInMinutes(bas.lastcachegenerationtimestamp) > 720 &&
@@ -146,7 +146,7 @@ No FAILs yet, because we don't know which one of these are critical until we act
 // The logic below is just to check the error states, the higher the number, the more severe the error state. We just show the highest error state as the parent error state.
 
 function computeBackendDotState(ds: any): string {
-  let highestErrorState: number = 0
+  let highestErrorState = 0
   if (dotStateOrderSubsection[ds.networkDotState] > highestErrorState) {
     highestErrorState = dotStateOrderSubsection[ds.networkDotState]
   }
@@ -156,7 +156,7 @@ function computeBackendDotState(ds: any): string {
   if (dotStateOrderSubsection[ds.cachingDotState] > highestErrorState) {
     highestErrorState = dotStateOrderSubsection[ds.cachingDotState]
   }
-  let result: string = 'status_section_unknown'
+  let result = 'status_section_unknown'
   Object.keys(dotStateOrderSection).forEach(function (key) {
     if (dotStateOrderSection[key] === highestErrorState) {
       result = key
@@ -165,14 +165,14 @@ function computeBackendDotState(ds: any): string {
   return result
 }
 function computeFrontendDotState(ds: any): string {
-  let highestErrorState: number = 0
+  let highestErrorState = 0
   if (dotStateOrderSubsection[ds.refresherDotState] > highestErrorState) {
     highestErrorState = dotStateOrderSubsection[ds.refresherDotState]
   }
   if (dotStateOrderSubsection[ds.inflightsDotState] > highestErrorState) {
     highestErrorState = dotStateOrderSubsection[ds.inflightsDotState]
   }
-  let result: string = 'status_section_unknown'
+  let result = 'status_section_unknown'
   Object.keys(dotStateOrderSection).forEach(function (key) {
     if (dotStateOrderSection[key] === highestErrorState) {
       result = key