Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: there were JSX issues #13

Merged
merged 5 commits into from
Sep 11, 2024
Merged

chore: there were JSX issues #13

merged 5 commits into from
Sep 11, 2024

Conversation

julianiff
Copy link
Contributor

Fixes issues with JSX and node type import

@julianiff julianiff requested a review from a team as a code owner September 11, 2024 07:52
@julianiff julianiff requested review from marguslant0 and removed request for a team September 11, 2024 07:52
@julianiff julianiff enabled auto-merge (squash) September 11, 2024 08:15
olivereisenhut
olivereisenhut reviewed Sep 11, 2024
View reviewed changes
Copy link
Contributor

@olivereisenhut olivereisenhut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty critical about whether all this configuration overhead is going to give us the benefit we're looking for.

But that's where I trust you guys, as you have a lot more experience with the whole JS ecosystem.

So LGTM from my side.

@julianiff
Copy link
Contributor Author

I'm pretty critical about whether all this configuration overhead is going to give us the benefit we're looking for.

But that's where I trust you guys, as you have a lot more experience with the whole JS ecosystem.

So LGTM from my side.

What would be another option?

olivereisenhut
olivereisenhut approved these changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@olivereisenhut olivereisenhut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with the exclude

@olivereisenhut
Copy link
Contributor

I also removed the node types are they're no longer needed with the exclude defined.

@olivereisenhut olivereisenhut merged commit c27c0f0 into main Sep 11, 2024
2 checks passed
@olivereisenhut olivereisenhut deleted the chore/update-apps branch September 11, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivereisenhut olivereisenhut olivereisenhut approved these changes

@marguslant0 marguslant0 Awaiting requested review from marguslant0 marguslant0 is a code owner automatically assigned from Frontify/apps-and-integrations

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julianiff @olivereisenhut