Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flyby sound improvements #28

Merged
merged 12 commits into from
Aug 28, 2023
Merged

Flyby sound improvements #28

merged 12 commits into from
Aug 28, 2023

Conversation

AViewFromTheTop
Copy link
Member

No description provided.

@Treetrain1
Copy link
Member

Treetrain1 commented Aug 25, 2023

I wonder if the player velocity is being used too strongly

@AViewFromTheTop
Copy link
Member Author

I wonder if the player velocity is being used too strongly

Not really-
We need to account for players moving alongside the other object (flybys shouldn’t really play then)
On top of that, they only play when moving vertically unless it’s going EXTREMELY fast, I have no clue what player velocity has to do with that

@AViewFromTheTop
Copy link
Member Author

Thinking about it now, maybe we just have to divide the vertical velocity and use slightly more sensitive calculation and it would work
I’ll get in that once I have the time today unless you have ideas before me

@AViewFromTheTop
Copy link
Member Author

Id prefer if you work on it now if you have the time because it’ll probably be like five or six hours for me until I can do anything

@AViewFromTheTop
Copy link
Member Author

Honestly we need some sort of debug renderer for this that can show us each vector being used and how long it is
Unfortunately who the hell knows how to do that..???!!!?!?!

@AViewFromTheTop
Copy link
Member Author

Maybe Ludo?

@Treetrain1
Copy link
Member

Id prefer if you work on it now if you have the time because it’ll probably be like five or six hours for me until I can do anything

man i just got online ☠️

@Treetrain1
Copy link
Member

Honestly we need some sort of debug renderer for this that can show us each vector being used and how long it is Unfortunately who the hell knows how to do that..???!!!?!?!

mojang
we get mojang to help us /j

@AViewFromTheTop
Copy link
Member Author

man i just got online ☠️

Wdym online

@AViewFromTheTop
Copy link
Member Author

Also I have to take a shower rn

@AViewFromTheTop
Copy link
Member Author

@Treetrain1 im so confused

@AViewFromTheTop
Copy link
Member Author

@Treetrain1 @MerpisMe FLYBYS ARE WORKINGGGGGG

@MerpisMe
Copy link
Contributor

can they clean my glasses

@AViewFromTheTop
Copy link
Member Author

can they clean my glasses

huh-
whats the connection im confused

@MerpisMe
Copy link
Contributor

can they clean my glasses

huh- whats the connection im confused

nothing i'm just wondering if they can
my glasses are pretty dirty rn

@AViewFromTheTop
Copy link
Member Author

did you try microwaving them

@MerpisMe
Copy link
Contributor

yea
listen if flybys can't clean my glasses then I DONT CARE ABOUT THEM‼️‼️‼️‼️‼️ /j
(congrats on fixing them!!!)

@AViewFromTheTop
Copy link
Member Author

yea listen if flybys can't clean my glasses then I DONT CARE ABOUT THEM‼️‼️‼️‼️‼️

fuck youuuuu

/j

/jellyfish

(congrats on fixing them!!!)

why

@MerpisMe
Copy link
Contributor

54321

@AViewFromTheTop
Copy link
Member Author

54321

gay communication at its finest

@AViewFromTheTop
Copy link
Member Author

what the fuck does 54321 mean

@MerpisMe
Copy link
Contributor

it's the amount of time you have left until the ballistic missiles i sent to your house land

run

@AViewFromTheTop
Copy link
Member Author

it's the amount of time you have left until the ballistic missiles i sent to your house land

run

well i hope thats soon

@MerpisMe
Copy link
Contributor

54321 years

@AViewFromTheTop
Copy link
Member Author

54321 years

god damnit

Copy link
Member

@Treetrain1 Treetrain1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the changes
glad they actually work now

this ready to merge?

@Treetrain1 Treetrain1 changed the title maybe better flybys? Flyby sound improvements Aug 27, 2023
@AViewFromTheTop
Copy link
Member Author

Love the changes glad they actually work now

this ready to merge?

Id like if you could see if there’s anything you can tweak, but if you can’t come up with anything just go ahead and merge

@Treetrain1
Copy link
Member

Love the changes glad they actually work now
this ready to merge?

Id like if you could see if there’s anything you can tweak, but if you can’t come up with anything just go ahead and merge

honestly ive had it work almost flawlessly
dont know if theres much to tweak at the moment
im just going to go ahead and merge

@Treetrain1 Treetrain1 merged commit e5970e0 into FrozenBlock:master Aug 28, 2023
1 check failed
@AViewFromTheTop
Copy link
Member Author

AViewFromTheTop commented Aug 28, 2023

honestly ive had it work almost flawlessly dont know if theres much to tweak at the moment im just going to go ahead and merge

oh LMAO it didn’t think my new implementation would be considered “almost flawless” thank you sidjdkdk
to be honest I think it has quite a few flaws that I can’t exactly fix, but luckily they’re small flaws anyway
it’s infinitely better than the bullshit I made before though lmfao

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants