-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: higher priority fee when late #186
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
without revealing the fee algo
MujkicA
approved these changes
Jan 13, 2025
MujkicA
previously approved these changes
Jan 14, 2025
a746294
to
4214585
Compare
… feat/higher_priority_fee_when_late
MujkicA
approved these changes
Feb 4, 2025
hal3e
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #180
Analyzed our worst offenders and it seems there is nothing else to do but bump the priority fee more as we get more desperate.
For context:
The priority fee percentage mentioned in the PR is explained nicely here:
The default priority fee estimator in Alloy requests the 20th percentile for the last 10 blocks and calculates the median max priority fee per gas from that.
This PR makes the percentile configurable by setting the min and max value. The percentile will increase between those as we get more and more behind reaching the max percentile on
max_l2_blocks_behind
.