Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: New Wallet Connector UI #24

Merged
merged 27 commits into from
Apr 1, 2024
Merged

feat: New Wallet Connector UI #24

merged 27 commits into from
Apr 1, 2024

Conversation

pedropereiradev
Copy link
Contributor

Changes

  • New UI Implemented

@vercel Vercel
Copy link

vercel bot commented Mar 29, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fuel-connectors ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 1, 2024 4:28pm

@CLAassistant
Copy link

CLAassistant commented Mar 29, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

luizstacio
luizstacio requested changes Mar 29, 2024
View reviewed changes
Copy link
Member

@luizstacio luizstacio left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feedbacks;

We need to pass a theme prop for the Connector to make it dark
Screenshot 2024-03-29 at 18 42 45

Use the same logo we have on the button also make sure to follow the theme
Screenshot 2024-03-29 at 18 43 53

Can you take a look if is possible to animate the transition between disconnected and connected? To Avoid the size the of card to change

Screenshot 2024-03-29 at 18 46 05 Screenshot 2024-03-29 at 18 46 12

Change the text Fuel Wallets Demo
Change the link from Build your own wallet integration to https://github.com/FuelLabs/fuel-connectors

luizstacio
luizstacio requested changes Mar 29, 2024
View reviewed changes
Copy link
Member

@luizstacio luizstacio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a general comment, remove all files that are inside the react-app that are not been used, such as fonts, CSS...

examples/react-app/.prettierrc Outdated Show resolved Hide resolved
examples/react-app/index.html Outdated Show resolved Hide resolved
examples/react-app/package.json Outdated Show resolved Hide resolved
examples/react-app/package.json Outdated Show resolved Hide resolved
examples/react-app/package.json Outdated Show resolved Hide resolved
examples/react-app/public/index.html Outdated Show resolved Hide resolved
examples/react-app/src/components/counter.tsx Outdated Show resolved Hide resolved
examples/react-app/src/fonts/index.css Show resolved Hide resolved
examples/react-app/src/hooks/useWallet.ts Outdated Show resolved Hide resolved
@luizstacio luizstacio changed the title Feat: New Wallet Connector UI feat: New Wallet Connector UI Mar 30, 2024
luizstacio
luizstacio requested changes Mar 30, 2024
View reviewed changes
.vscode/settings.json Outdated Show resolved Hide resolved
luizstacio
luizstacio requested changes Mar 30, 2024
View reviewed changes
examples/react-app/src/main.tsx Outdated Show resolved Hide resolved
@luizstacio luizstacio marked this pull request as ready for review April 1, 2024 18:56
@luizstacio luizstacio merged commit d2faee0 into FuelLabs:main Apr 1, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luizstacio luizstacio luizstacio approved these changes

@pedronauck pedronauck Awaiting requested review from pedronauck pedronauck is a code owner

@LuizAsFight LuizAsFight Awaiting requested review from LuizAsFight LuizAsFight is a code owner

@helciofranco helciofranco Awaiting requested review from helciofranco helciofranco is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pedropereiradev @CLAassistant @luizstacio