-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: walletconnect connector #43
feat: walletconnect connector #43
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@pedropereiradev is attempting to deploy a commit to the Fuel Labs Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also the tests are failing because of lack of coverage, I understand it can be difficult to mock the walletconnect modal, if you don't find a ready solution, you can reduce the trashhold of the test coverage for the specific package.
Co-authored-by: Luiz Estácio | stacio.eth <luizstacio@gmail.com>
…eiradev/fuel-connectors into feat/ethereum-wallets-connector
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've raised the following issues here:
#54
#53
With the Ethereum Wallets connection option, I'm finding it virtually impossible to connect to Trust wallet or Coinbase wallet with the Sepolia network. I'm wondering if this is a problem on their side though rather than on the Fuel side.
I think I had this problem when I first started to test Connectors and then tried to Connect Metamask, ...it ended up that a fix was possible on the Fuel side. (#35)
Will it be the same with these other wallets? Linking up with mainnets is never an issue.
WalletConnect I can scan with the camera on my iPhone (I don't have an Android phone), it always wants to open Metamask which I would kind of expect with iOS. It's always impossible to change the default app on iOS.
I can scan the WalletConnect QR codes from within different wallet apps though and each time is seems to work ok, except it always want to connect Mainnet addresses to the Fuel Connector.
I cannot imagine that this is something that can be changed on the Fuel side, or is it?
close in favor of #61 |
No description provided.