Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: walletconnect connector #43

Conversation

pedropereiradev
Copy link
Contributor

No description provided.

Copy link

vercel bot commented Apr 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fuel-connectors ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 13, 2024 10:11pm

@pedropereiradev pedropereiradev changed the title feat: ethereum wallets connector feat: walletconnect connector Apr 8, 2024
Copy link

vercel bot commented Apr 10, 2024

@pedropereiradev is attempting to deploy a commit to the Fuel Labs Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Member

@luizstacio luizstacio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also the tests are failing because of lack of coverage, I understand it can be difficult to mock the walletconnect modal, if you don't find a ready solution, you can reduce the trashhold of the test coverage for the specific package.

examples/react-app/.env Outdated Show resolved Hide resolved
examples/react-app/src/main.tsx Outdated Show resolved Hide resolved
packages/evm-connector/src/EvmWalletConnector.ts Outdated Show resolved Hide resolved
packages/walletconnect-connector/src/types.ts Outdated Show resolved Hide resolved
examples/react-app/src/main.tsx Outdated Show resolved Hide resolved
Copy link

@HoTandy HoTandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've raised the following issues here:
#54
#53

With the Ethereum Wallets connection option, I'm finding it virtually impossible to connect to Trust wallet or Coinbase wallet with the Sepolia network. I'm wondering if this is a problem on their side though rather than on the Fuel side.
I think I had this problem when I first started to test Connectors and then tried to Connect Metamask, ...it ended up that a fix was possible on the Fuel side. (#35)
Will it be the same with these other wallets? Linking up with mainnets is never an issue.

WalletConnect I can scan with the camera on my iPhone (I don't have an Android phone), it always wants to open Metamask which I would kind of expect with iOS. It's always impossible to change the default app on iOS.
I can scan the WalletConnect QR codes from within different wallet apps though and each time is seems to work ok, except it always want to connect Mainnet addresses to the Fuel Connector.
I cannot imagine that this is something that can be changed on the Fuel side, or is it?

@luizstacio
Copy link
Member

close in favor of #61

@luizstacio luizstacio closed this Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants