Skip to content

Commit

Permalink
add one more test and change variable name in tests
Browse files Browse the repository at this point in the history
  • Loading branch information
AurelienFT committed Feb 5, 2025
1 parent 2a96eff commit 95ee362
Showing 1 changed file with 24 additions and 8 deletions.
32 changes: 24 additions & 8 deletions crates/storage/src/transactional.rs
Original file line number Diff line number Diff line change
Expand Up @@ -670,8 +670,8 @@ mod test {
let storage = InMemoryStorage::<Column>::default();
let mut view = storage.read_transaction();
let key = vec![0xA, 0xB, 0xC];
let expected = Value::from([1, 2, 3]);
view.put(&key, Column::Metadata, expected.clone()).unwrap();
let value = Value::from([1, 2, 3]);
view.put(&key, Column::Metadata, value).unwrap();
// test
let mut buf = [0; 3];
let ret = view.read(&key, Column::Metadata, 0, &mut buf).unwrap();
Expand All @@ -686,8 +686,8 @@ mod test {
let storage = InMemoryStorage::<Column>::default();
let mut view = storage.read_transaction();
let key = vec![0xA, 0xB, 0xC];
let expected = Value::from([1, 2, 3]);
view.put(&key, Column::Metadata, expected.clone()).unwrap();
let value = Value::from([1, 2, 3]);
view.put(&key, Column::Metadata, value).unwrap();
// test
let mut buf = [0; 2];
let ret = view.read(&key, Column::Metadata, 0, &mut buf).unwrap();
Expand All @@ -696,14 +696,30 @@ mod test {
assert_eq!(buf, [1, 2]);
}

#[test]
fn read_returns_from_view_with_offset() {
// setup
let storage = InMemoryStorage::<Column>::default();
let mut view = storage.read_transaction();
let key = vec![0xA, 0xB, 0xC];
let value = Value::from([1, 2, 3]);
view.put(&key, Column::Metadata, value).unwrap();
// test
let mut buf = [0; 2];
let ret = view.read(&key, Column::Metadata, 1, &mut buf).unwrap();
// verify
assert_eq!(ret, Some(2));
assert_eq!(buf, [2, 3]);
}

#[test]
fn read_returns_from_view_buf_bigger() {
// setup
let storage = InMemoryStorage::<Column>::default();
let mut view = storage.read_transaction();
let key = vec![0xA, 0xB, 0xC];
let expected = Value::from([1, 2, 3]);
view.put(&key, Column::Metadata, expected.clone()).unwrap();
let value = Value::from([1, 2, 3]);
view.put(&key, Column::Metadata, value).unwrap();
// test
let mut buf = [0; 4];
let ret = view.read(&key, Column::Metadata, 0, &mut buf).unwrap_err();
Expand All @@ -717,8 +733,8 @@ mod test {
let storage = InMemoryStorage::<Column>::default();
let mut view = storage.read_transaction();
let key = vec![0xA, 0xB, 0xC];
let expected = Value::from([1, 2, 3]);
view.put(&key, Column::Metadata, expected.clone()).unwrap();
let value = Value::from([1, 2, 3]);
view.put(&key, Column::Metadata, value).unwrap();
// test
let mut buf = [0; 3];
let ret = view.read(&key, Column::Metadata, 1, &mut buf).unwrap_err();
Expand Down

0 comments on commit 95ee362

Please sign in to comment.