Create new simulation using the actual gas price service #2538
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…data_tests.rs Co-authored-by: Rafał Chabowski <88321181+rafal-ch@users.noreply.github.com>
…-be-received-out-of-order
…to feature/init-task-for-v1-gas-price-service
…ew-gas-price-simulation
…ew-gas-price-simulation
|
think this PR needs to be rebased correctly 
seems like all the commits from the prev branch are included |
netrome
reviewed
Jan 27, 2025
|
|
||
| let gas = gas_used; | ||
| let new_gas_price = self.shared_algo.next_gas_price(); | ||
| let gas_price_factor = 1_150_000; // TODO: Read from CLI/config |
There was a problem hiding this comment.
To be done now or in a follow-up?
|
|
||
| if record.l1_block_number != 0 { | ||
| tracing::debug!("adding new DA info: {:?}", record); | ||
| // TODO: Check if these are generated correctly. |
There was a problem hiding this comment.
Why are we doing executor changes in this PR?
Comment on lines
+43
to
+44
| #[async_trait] | ||
| impl L2BlockSource for SimulatedL2Blocks { |
There was a problem hiding this comment.
Unrelated to this PR; Do we still need async_trait? These are our traits right? We shouldn't need the legacy async_trait macro anymore since async functions in traits have been stabilized.
1 task
|
Closing in favor of: |
rymnc
pushed a commit
that referenced
this pull request
Feb 5, 2025
## Linked Issues/PRs <!-- List of related issues/PRs --> Needed for #2538 ## Description <!-- List of detailed changes --> These need to be exposed so we can move the simulation to the fuel-core-utils ## Checklist - [ ] Breaking changes are clearly marked as such in the PR description and changelog
freestardev711
added a commit
to freestardev711/core-fuel
that referenced
this pull request
Apr 5, 2025
## Linked Issues/PRs <!-- List of related issues/PRs --> Needed for FuelLabs/fuel-core#2538 ## Description <!-- List of detailed changes --> These need to be exposed so we can move the simulation to the fuel-core-utils ## Checklist - [ ] Breaking changes are clearly marked as such in the PR description and changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked Issues/PRs
closes #2181
Description
This PR adds a new simulator (a successor to the
gas-price-analysisbin).It includes the ability to run
singlesimulations:or
optimizationsimulations which tries to find goodpanddvalues for the given dataset:Both will produce and chart of the simulated data a la:
and print a summary:
The goal is to use this with larger datasets to select appropriate p/d values for the V1 gas price algorithm/service
Checklist
Before requesting review
After merging, notify other teams
[Add or remove entries as needed]