Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(wasm-executor): add nicer error if you missed a feature flag during compilation #2653

Merged
merged 5 commits into from
Feb 10, 2025
Merged

chore(wasm-executor): add nicer error if you missed a feature flag during compilation #2653

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9f8f192
chore(wasm-executor): add nicer error if you missed a feature flag du…
rymnc Jan 31, 2025
107ffc6
Merge branch 'master' into wasm-executor/verbose-errors
rymnc Feb 3, 2025
d08fe40
Merge branch 'master' into wasm-executor/verbose-errors
rymnc Feb 7, 2025
7d39b38
Merge branch 'master' into wasm-executor/verbose-errors
rymnc Feb 7, 2025
4e8ba80
Merge branch 'master' into wasm-executor/verbose-errors
rymnc Feb 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,15 +8,16 @@ and this project adheres to [Semantic Versioning](http://semver.org/).

### Added
- [2635](https://github.com/FuelLabs/fuel-core/pull/2635): Add metrics to gas price service
- [2553](https://github.com/FuelLabs/fuel-core/pull/2553): Scaffold global merkle root storage crate.
- [2598](https://github.com/FuelLabs/fuel-core/pull/2598): Add initial test suite for global merkle root storage updates.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice not to touch old changes in changelog=)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah it got auto formatted



### Changed
- [2387](https://github.com/FuelLabs/fuel-core/pull/2387): Update description `tx-max-depth` flag.
- [2630](https://github.com/FuelLabs/fuel-core/pull/2630): Removed some noisy `tracing::info!` logs
- [2643](https://github.com/FuelLabs/fuel-core/pull/2643): Before this fix when tip is zero, transactions that use 30M have the same priority as transactions with 1M gas. Now they are correctly ordered.
- [2653](https://github.com/FuelLabs/fuel-core/pull/2653): Added cleaner error for wasm-executor upon failed deserialization.

### Added
- [2553](https://github.com/FuelLabs/fuel-core/pull/2553): Scaffold global merkle root storage crate.
- [2598](https://github.com/FuelLabs/fuel-core/pull/2598): Add initial test suite for global merkle root storage updates.

### Fixed
- [2632](https://github.com/FuelLabs/fuel-core/pull/2632): Improved performance of certain async trait impls in the gas price service.
Expand Down
7 changes: 6 additions & 1 deletion crates/services/upgradable-executor/src/instance.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -636,6 +636,11 @@ impl Instance<InputData> {
.expect("Memory was initialized above; qed");
let slice = &memory.data(&self.store)[ptr..ptr.saturating_add(len)];

postcard::from_bytes(slice).map_err(|e| anyhow::anyhow!(e))
postcard::from_bytes(slice).map_err(|e| {
match e {
postcard::Error::SerdeDeCustom => anyhow::anyhow!(e).context("Error in Deserialization; check feature flags of wasm module during compilation"),
_ => anyhow::anyhow!(e).context("Error in Deserialization; fatal"),
}
})
}
}
Loading