Dry run in the past #2661

Dentosal · 2025-02-03T14:56:30Z

Closes #2062

Description

Support dry running in past blocks. It's behind the --historical-execution flag.

Checklist

Breaking changes are clearly marked as such in the PR description and changelog
New behavior is reflected in tests
The specification matches the implemented behavior (link update PR if changes are needed)

Before requesting review

I have reviewed the code myself
I have created follow-up issues caused by this PR and linked them here

After merging, notify other teams

Rust SDK
Platform documentation (for out-of-organization contributors, the person merging the PR will do this)

facebook/rocksdb#11349

crates/services/upgradable-executor/src/executor.rs

Dentosal · 2025-02-06T16:30:17Z

One test is failing due to a pthread issue (that I cannot reproduce locally). I'll have to setup a linux env to figure this one out, unless someone already knows what's the issue.

netrome · 2025-02-06T18:50:52Z

One test is failing due to a pthread issue (that I cannot reproduce locally). I'll have to setup a linux env to figure this one out, unless someone already knows what's the issue.

Let me see if I can reproduce it on one of my Linux machines.

netrome · 2025-02-06T18:55:16Z

One test is failing due to a pthread issue (that I cannot reproduce locally). I'll have to setup a linux env to figure this one out, unless someone already knows what's the issue.

Which test? All I can see is fuel-core-e2e-client::integration_tests works_in_multinode_local_env which I think is flaky.

Dentosal · 2025-02-07T20:44:08Z

One test is failing due to a pthread issue (that I cannot reproduce locally). I'll have to setup a linux env to figure this one out, unless someone already knows what's the issue.

Which test? All I can see is fuel-core-e2e-client::integration_tests works_in_multinode_local_env which I think is flaky.

dry_run__correct_contract_state_in_past_blocks (https://github.com/FuelLabs/fuel-core/actions/runs/13166313215/job/36747248348?pr=2661)

xgreenx

Looks good to me=) Small things to fix and good to go form my side=D

xgreenx · 2025-02-07T21:18:30Z

crates/fuel-core/src/schema/tx.rs

+        if block_height.is_some() && !config.debug {
+            return Err(anyhow::anyhow!(
+                "The `blockHeight` parameter requires the `--debug` option"
+            )
+            .into());
+        }


It still uses --debug and .debug.

Fixed in 2245cc1

xgreenx · 2025-02-07T21:20:11Z

crates/fuel-core/src/service/sub_services.rs

+    let allow_historical_execution = config.combined_db_config.database_type
+        == DbType::RocksDb
+        && config.historical_execution;


I think we need allow it on config level for the whole fuel-core, including the GraphQL and other services.

netrome · 2025-02-10T07:05:43Z

dry_run__correct_contract_state_in_past_blocks (https://github.com/FuelLabs/fuel-core/actions/runs/13166313215/job/36747248348?pr=2661)

Okay I cannot reproduce this locally either. I tried both the latest version, on 52a981a and on 07013c7.

I'll proceed with reviewing and assume this was caused cosmic background radiation.

netrome

Looks good to me 👍

netrome · 2025-02-10T08:32:10Z

tests/tests/state_rewind.rs

+}
+
+#[tokio::test(flavor = "multi_thread")]
+async fn dry_run__correct_utxoid_state_in_past_blocks() -> anyhow::Result<()> {


Nit: It would be nice to add "Given" "When" "Then" sections to this test.

netrome · 2025-02-10T08:34:46Z

crates/client/assets/schema.sdl

@@ -760,7 +760,7 @@ type Mutation {
 	"""
 	Execute a dry-run of multiple transactions using a fork of current state, no changes are committed.
 	"""
-	dryRun(txs: [HexString!]!, utxoValidation: Boolean, gasPrice: U64): [DryRunTransactionExecutionStatus!]!
+	dryRun(txs: [HexString!]!, utxoValidation: Boolean, gasPrice: U64, blockHeight: U32): [DryRunTransactionExecutionStatus!]!


Perhaps we should consider combining the utxoValidation, gasPrice and blockHeight args into a single input struct. This would allow us to add more fields in the future without breaking the API (though currently it's still breaking if we use the new arg in the client until we resolve #2676).

If you think this sounds sensible, we could create a follow-up issue for it.

The extra args are already optional, isn't that already good enough? But it's good to consider the forward compatibility. I'm not sure if a struct would help in this case?

rafal-ch

A couple of post-merge questions and comments.

crates/services/upgradable-executor/src/executor.rs

tests/test-helpers/src/counter_contract.rs

tests/tests/state_rewind.rs

Implement dry run in the past

64016b0

Dentosal self-assigned this Feb 3, 2025

Dentosal added 3 commits February 3, 2025 17:06

Add changelog entry

312077b

Fix typo

883a51b

Require --debug flag for setting block height to past

b7dfc6e

Dentosal marked this pull request as ready for review February 3, 2025 15:11

Dentosal requested review from xgreenx, MitchTurner, netrome, acerone85, rafal-ch, rymnc and AurelienFT as code owners February 3, 2025 15:11

Dentosal and others added 4 commits February 5, 2025 16:53

Merge branch 'master' into dento/2062_dry_run_in_the_past

3a0d381

Fix broken merge

07013c7

Workaround linux pthread issue of rocksdb

0dd8f64

facebook/rocksdb#11349

Merge branch 'master' into dento/2062_dry_run_in_the_past

52a981a

xgreenx reviewed Feb 6, 2025

View reviewed changes

crates/services/upgradable-executor/src/executor.rs Show resolved Hide resolved

Dentosal and others added 2 commits February 7, 2025 22:44

Merge branch 'master' into dento/2062_dry_run_in_the_past

77e0b89

Move from --debug to --historical-execution, force off for InMemory db

1dd6847

Dentosal mentioned this pull request Feb 7, 2025

Execution tracing: GraphQL query to get storage inputs for past blocks #2491

Open

5 tasks

fmt

8345f46

xgreenx reviewed Feb 7, 2025

View reviewed changes

Dentosal mentioned this pull request Feb 7, 2025

Bugfix: more receipt generation issues with debugger FuelLabs/fuel-vm#908

Merged

6 tasks

Properly use --historical-execution

2245cc1

Dentosal requested a review from xgreenx February 7, 2025 21:35

Enable --historical-execution for dry run in past test

d3984ca

Dentosal mentioned this pull request Feb 9, 2025

GraphQL: historical contract storage and balances #2682

Draft

4 tasks

Error on startup if --historical-execution passed without RocksDB

bbbedd1

xgreenx approved these changes Feb 10, 2025

View reviewed changes

netrome approved these changes Feb 10, 2025

View reviewed changes

Dentosal merged commit ed6aa39 into master Feb 10, 2025
33 checks passed

Dentosal deleted the dento/2062_dry_run_in_the_past branch February 10, 2025 09:59

rafal-ch reviewed Feb 10, 2025

View reviewed changes

crates/services/upgradable-executor/src/executor.rs Show resolved Hide resolved

crates/services/upgradable-executor/src/executor.rs Show resolved Hide resolved

tests/test-helpers/src/counter_contract.rs Show resolved Hide resolved

tests/tests/state_rewind.rs Show resolved Hide resolved

Dentosal mentioned this pull request Feb 10, 2025

Dry run in the past: passing in zero height incorrectly uses latest state #2683

Open

Dentosal added a commit that referenced this pull request Feb 10, 2025

Fix #2661 (comment)

294ea09

Dentosal added a commit that referenced this pull request Feb 10, 2025

Fix #2661 (comment)

9eeee84

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dry run in the past #2661

Dry run in the past #2661

Dentosal commented Feb 3, 2025 •

edited

Loading

Dentosal commented Feb 6, 2025

netrome commented Feb 6, 2025

netrome commented Feb 6, 2025

Dentosal commented Feb 7, 2025 •

edited

Loading

xgreenx left a comment

xgreenx Feb 7, 2025

Dentosal Feb 7, 2025

xgreenx Feb 7, 2025

Dentosal Feb 10, 2025

netrome commented Feb 10, 2025

netrome left a comment

netrome Feb 10, 2025

netrome Feb 10, 2025

Dentosal Feb 10, 2025

rafal-ch left a comment

Dry run in the past #2661

Dry run in the past #2661

Conversation

Dentosal commented Feb 3, 2025 • edited Loading

Description

Checklist

Before requesting review

After merging, notify other teams

Dentosal commented Feb 6, 2025

netrome commented Feb 6, 2025

netrome commented Feb 6, 2025

Dentosal commented Feb 7, 2025 • edited Loading

xgreenx left a comment

Choose a reason for hiding this comment

xgreenx Feb 7, 2025

Choose a reason for hiding this comment

Dentosal Feb 7, 2025

Choose a reason for hiding this comment

xgreenx Feb 7, 2025

Choose a reason for hiding this comment

Dentosal Feb 10, 2025

Choose a reason for hiding this comment

netrome commented Feb 10, 2025

netrome left a comment

Choose a reason for hiding this comment

netrome Feb 10, 2025

Choose a reason for hiding this comment

netrome Feb 10, 2025

Choose a reason for hiding this comment

Dentosal Feb 10, 2025

Choose a reason for hiding this comment

rafal-ch left a comment

Choose a reason for hiding this comment

Dentosal commented Feb 3, 2025 •

edited

Loading

Dentosal commented Feb 7, 2025 •

edited

Loading